Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][nodejs] System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http11.SendAsync_ContentLengthAndTransferEncodingHeaders_IgnoreContentLength #69085

Closed
radical opened this issue May 10, 2022 · 3 comments · Fixed by #69109
Labels
arch-wasm WebAssembly architecture area-System.Net.Http blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms'
Milestone

Comments

@radical
Copy link
Member

radical commented May 10, 2022

Build, and log. Seen on #68921 .

Breaking with nodejs:

[23:38:31] fail: [FAIL] System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http11.SendAsync_ContentLengthAndTransferEncodingHeaders_IgnoreContentLength
[23:38:31] info: System.Net.Http.HttpRequestException : FetchError: request to http://127.0.0.1:40499/ failed, reason: Parse Error: Content-Length can't be present with Transfer-Encoding
[23:38:31] info: ---- System.Runtime.InteropServices.JavaScript.JSException : FetchError: request to http://127.0.0.1:40499/ failed, reason: Parse Error: Content-Length can't be present with Transfer-Encoding
[23:38:31] info:    at System.Net.Http.BrowserHttpHandler.<SendAsync>g__Impl|56_0(HttpRequestMessage request, CancellationToken cancellationToken)
[23:38:31] info:    at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
[23:38:31] info:    at System.Net.Http.Functional.Tests.HttpClientHandlerTest_Headers.<>c__DisplayClass20_0.<<SendAsync_ContentLengthAndTransferEncodingHeaders_IgnoreContentLength>b__1>d.MoveNext()
[23:38:31] info: --- End of stack trace from previous location ---
[23:38:31] info:    at System.Net.Test.Common.LoopbackServer.AcceptConnectionAsync(Func`2 funcAsync)
[23:38:31] info:    at System.Net.Http.Functional.Tests.HttpClientHandlerTest_Headers.<SendAsync_ContentLengthAndTransferEncodingHeaders_IgnoreContentLength>b__20_0(LoopbackServer server, Uri uri)
[23:38:31] info:    at System.Net.Test.Common.LoopbackServer.CreateServerAsync(Func`2 funcAsync, Options options)
[23:38:31] info:    at System.Net.Http.Functional.Tests.HttpClientHandlerTest_Headers.SendAsync_ContentLengthAndTransferEncodingHeaders_IgnoreContentLength()
[23:38:31] info: --- End of stack trace from previous location ---
[23:38:31] info: ----- Inner Stack Trace -----
[23:38:31] info:    at System.Net.Http.BrowserHttpHandler.<SendAsync>g__Impl|56_0(HttpRequestMessage request, CancellationToken cancellationToken)
[23:38:31] fail: (node:713) Warning: Setting the NODE_TLS_REJECT_UNAUTHORIZED environment variable to '0' makes TLS connections and HTTPS requests insecure by disabling certificate verification.

This test was just introduced in #69016 .

cc @pedrobsaila @ManickaP @wfurt @maraf @pavelsavara

@radical radical added arch-wasm WebAssembly architecture area-System.Net.Http blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' labels May 10, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label May 10, 2022
@ghost
Copy link

ghost commented May 10, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Build, and log. Seen on #68921 .

Breaking with nodejs:

[23:38:31] fail: [FAIL] System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http11.SendAsync_ContentLengthAndTransferEncodingHeaders_IgnoreContentLength
[23:38:31] info: System.Net.Http.HttpRequestException : FetchError: request to http://127.0.0.1:40499/ failed, reason: Parse Error: Content-Length can't be present with Transfer-Encoding
[23:38:31] info: ---- System.Runtime.InteropServices.JavaScript.JSException : FetchError: request to http://127.0.0.1:40499/ failed, reason: Parse Error: Content-Length can't be present with Transfer-Encoding
[23:38:31] info:    at System.Net.Http.BrowserHttpHandler.<SendAsync>g__Impl|56_0(HttpRequestMessage request, CancellationToken cancellationToken)
[23:38:31] info:    at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
[23:38:31] info:    at System.Net.Http.Functional.Tests.HttpClientHandlerTest_Headers.<>c__DisplayClass20_0.<<SendAsync_ContentLengthAndTransferEncodingHeaders_IgnoreContentLength>b__1>d.MoveNext()
[23:38:31] info: --- End of stack trace from previous location ---
[23:38:31] info:    at System.Net.Test.Common.LoopbackServer.AcceptConnectionAsync(Func`2 funcAsync)
[23:38:31] info:    at System.Net.Http.Functional.Tests.HttpClientHandlerTest_Headers.<SendAsync_ContentLengthAndTransferEncodingHeaders_IgnoreContentLength>b__20_0(LoopbackServer server, Uri uri)
[23:38:31] info:    at System.Net.Test.Common.LoopbackServer.CreateServerAsync(Func`2 funcAsync, Options options)
[23:38:31] info:    at System.Net.Http.Functional.Tests.HttpClientHandlerTest_Headers.SendAsync_ContentLengthAndTransferEncodingHeaders_IgnoreContentLength()
[23:38:31] info: --- End of stack trace from previous location ---
[23:38:31] info: ----- Inner Stack Trace -----
[23:38:31] info:    at System.Net.Http.BrowserHttpHandler.<SendAsync>g__Impl|56_0(HttpRequestMessage request, CancellationToken cancellationToken)
[23:38:31] fail: (node:713) Warning: Setting the NODE_TLS_REJECT_UNAUTHORIZED environment variable to '0' makes TLS connections and HTTPS requests insecure by disabling certificate verification.

This test was just introduced in #69016 .

cc @pedrobsaila @wfurt @maraf @pavelsavara

Author: radical
Assignees: -
Labels:

arch-wasm, area-System.Net.Http, blocking-clean-ci

Milestone: -

@radical radical changed the title [wasm] System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http11.SendAsync_ContentLengthAndTransferEncodingHeaders_IgnoreContentLength [wasm][nodejs] System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http11.SendAsync_ContentLengthAndTransferEncodingHeaders_IgnoreContentLength May 10, 2022
@wfurt
Copy link
Member

wfurt commented May 10, 2022

We should probably exclude the test from browsers. cc: @pedrobsaila.

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label May 10, 2022
@maraf
Copy link
Member

maraf commented May 10, 2022

The test works on browser, we can disable it just for NodeJS.

@ghost ghost removed untriaged New issue has not been triaged by the area owner in-pr There is an active PR which will close this issue when it is merged labels May 10, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jun 10, 2022
@karelz karelz added this to the 7.0.0 milestone Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Net.Http blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms'
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants