Reenable System.Runtime.Serialization.Xml.Tests
#68921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was disabled due to dotnet#59926, which was then tracked by dotnet#61061 . The stack overflow is due to one specific test though, and the rest of the tests can be enabled if we skip this one - `DCS_DeeplyLinkedData`.
radical
added
the
disabled-test
|
The condition on the library in tests.proj covers non-wasm cases too, but the issue that it references is closed. I will run non-wasm jobs also to confirm that this doesn't break others. |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThis was disabled due to #59926, The stack overflow is due to one specific test though, and the rest of
|
vargaz
approved these changes
May 5, 2022
lewing
approved these changes
May 5, 2022
|
SkipOnPlatform would be better imho, this is unlikely to be fixed. |
.. unlikely to be fixed (- vargaz).
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
steveisok
approved these changes
May 9, 2022
This was referenced May 10, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was disabled due to #59926,
which was then tracked by #61061
.
The stack overflow is due to one specific test though, and the rest of
the tests can be enabled if we skip this one -
DCS_DeeplyLinkedData.Fixes #61061 .