Some MonoTargetsTasks project references are not removed during source build

[lbussell]

We are seeing a new prebuilt package reported in source-build, Microsoft.DotNet.CilStrip.Sources.7.0.0-beta.22214.1.

It seems like AssemblyStripper.csproj is being picked up by the **/*.csproj pattern in tasks.proj and it is referencing the prebuilt:

runtime/src/tasks/tasks.proj

Lines 2 to 9 in f246a5a

	<ItemGroup>
	<ProjectReference Include="$(MSBuildThisFileDirectory)**\*.csproj" />
	<!-- These projects do not need to be built during source-build. -->
	<!-- For example, they may take dependencies on pre-built packages that aren't build-from-source. e.g. 'Microsoft.DotNet.CilStrip.Sources' -->
	<ProjectReference Remove="MonoTargetsTasks\MonoTargetsTasks.csproj"
	Condition="'$(DotNetBuildFromSource)' == 'true'" />
	</ItemGroup>

This target should instead ignore all .csproj files under MonoTargetsTasks/.

[ghost]

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

---

We are seeing a new prebuilt package reported in source-build, Microsoft.DotNet.CilStrip.Sources.7.0.0-beta.22214.1.

It seems like AssemblyStripper.csproj is being picked up by the **/*.csproj pattern in tasks.proj and it is referencing the prebuilt:

runtime/src/tasks/tasks.proj

Lines 2 to 9 in f246a5a

	<ItemGroup>
	<ProjectReference Include="$(MSBuildThisFileDirectory)**\*.csproj" />
	<!-- These projects do not need to be built during source-build. -->
	<!-- For example, they may take dependencies on pre-built packages that aren't build-from-source. e.g. 'Microsoft.DotNet.CilStrip.Sources' -->
	<ProjectReference Remove="MonoTargetsTasks\MonoTargetsTasks.csproj"
	Condition="'$(DotNetBuildFromSource)' == 'true'" />
	</ItemGroup>

It seems like this target should instead ignore all .csproj files under MonoTargetsTasks/.

Author:	lbussell
Assignees:	-
Labels:	area-Infrastructure-libraries
Milestone:	-

[ghost]

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

---

We are seeing a new prebuilt package reported in source-build, Microsoft.DotNet.CilStrip.Sources.7.0.0-beta.22214.1.

It seems like AssemblyStripper.csproj is being picked up by the **/*.csproj pattern in tasks.proj and it is referencing the prebuilt:

runtime/src/tasks/tasks.proj

Lines 2 to 9 in f246a5a

	<ItemGroup>
	<ProjectReference Include="$(MSBuildThisFileDirectory)**\*.csproj" />
	<!-- These projects do not need to be built during source-build. -->
	<!-- For example, they may take dependencies on pre-built packages that aren't build-from-source. e.g. 'Microsoft.DotNet.CilStrip.Sources' -->
	<ProjectReference Remove="MonoTargetsTasks\MonoTargetsTasks.csproj"
	Condition="'$(DotNetBuildFromSource)' == 'true'" />
	</ItemGroup>

This target should instead ignore all .csproj files under MonoTargetsTasks/.

Author:	lbussell
Assignees:	-
Labels:	source-build, area-Infrastructure-mono
Milestone:	7.0.0

[ericstj]

cc @lambdageek @radical per #59720

It's a bit ironic that this "source" package is treated as a "prebuilt". I wonder if this component is needed for source build or not. If not then adding to the remove as @lbussell suggests would be the fix:

<ProjectReference Remove="MonoTargetsTasks\MonoTargetsTasks.csproj;
                          MonoTargetsTasks\ILStrip\AssemblyStripper\AssemblyStripper.csproj" 
                     Condition="'$(DotNetBuildFromSource)' == 'true'" />

[eerhardt]

I don't believe any of the Mono workloads tasks are needed for source-build. So I think not building AssemblyStripper during source-build makes sense.

See also #60315.