Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude AssemblyStripper from source-build #71691

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Exclude AssemblyStripper from source-build #71691

merged 1 commit into from
Jul 6, 2022

Conversation

MichaelSimons
Copy link
Member

Fixes #69460

@ghost ghost assigned MichaelSimons Jul 6, 2022
@ghost
Copy link

ghost commented Jul 6, 2022

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #69460

Author: MichaelSimons
Assignees: -
Labels:

area-Infrastructure-mono
Milestone: -

eerhardt
eerhardt approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@runfoapp runfoapp bot mentioned this pull request Jul 6, 2022
Closed
@MichaelSimons
Copy link
Member Author

Test failure appears unrelated to this change and was addressed by #71684

@MichaelSimons MichaelSimons merged commit 6d384fc into dotnet:main Jul 6, 2022
@MichaelSimons MichaelSimons deleted the issue-69460 branch July 6, 2022 22:18
@ghost ghost locked as resolved and limited conversation to collaborators Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lbussell lbussell lbussell approved these changes

@eerhardt eerhardt eerhardt approved these changes

@ericstj ericstj Awaiting requested review from ericstj

Assignees

@MichaelSimons MichaelSimons

Labels
area-Infrastructure-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some MonoTargetsTasks project references are not removed during source build
3 participants
@MichaelSimons @eerhardt @lbussell