Unable to bind Dictionary with key type "Enum" when key string case is different

[mortifactor]

Description

Hello.
Since ASP.NET Core documentation says:

Configuration keys: Are case-insensitive. For example, `ConnectionString` and `connectionstring` are treated as equivalent keys.

https://github.com/dotnet/AspNetCore.Docs/blob/c875045a940e6ce3d24c24573309ff4be71d4fde/aspnetcore/fundamentals/configuration/index.md?plain=1#L404

I suppose that enum keys should be handled the same way as strings.
But at the moment ConfigurationBinder throws an error as it uses "Enum.Parse" method:

runtime/src/libraries/Microsoft.Extensions.Configuration.Binder/src/ConfigurationBinder.cs

Line 547 in 95d64e8

object key = keyTypeIsEnum ? Enum.Parse(keyType, child.Key) : child.Key;

Reproduction Steps

Create settings class:

public class TestConf : Dictionary<TestEnum, string>
{
}

public enum TestEnum
{
    Test1,
    Test2,
}

Modify appsettings.json:

"TestConf": {
  "Test1": "foo",
  "test2": "bar"
}

Register a configuration in Program.cs:

builder.Services.Configure<TestConf>(builder.Configuration.GetSection(nameof(TestConf)));

And finally try somewhere to get options value:

[HttpGet("test")]
public async Task<IActionResult> TestAppsettingsForIssue([FromServices] IOptionsSnapshot<TestConf> testConf)
{
    var t = testConf.Value;
    return Ok();
}

I am not sure if this is a bug or intentional behavior.

Expected behavior

Since ASP.NET Core documentation says Configuration keys are case-insensitive it should not throw an error.

Actual behavior

It throws an error System.ArgumentException: Requested value 'test2' was not found.

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

[ghost]

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

Hello.
Since ASP.NET Core documentation says:

Configuration keys: Are case-insensitive. For example, `ConnectionString` and `connectionstring` are treated as equivalent keys.

https://github.com/dotnet/AspNetCore.Docs/blob/c875045a940e6ce3d24c24573309ff4be71d4fde/aspnetcore/fundamentals/configuration/index.md?plain=1#L404

I suppose that enum keys should be handled the same way as strings.
But at the moment ConfigurationBinder throws an error as it uses "Enum.Parse" method:

runtime/src/libraries/Microsoft.Extensions.Configuration.Binder/src/ConfigurationBinder.cs

Line 547 in 95d64e8

object key = keyTypeIsEnum ? Enum.Parse(keyType, child.Key) : child.Key;

Reproduction Steps

Create settings class:

public class TestConf : Dictionary<TestEnum, string>
{
}

public enum TestEnum
{
    Test1,
    Test2,
}

Modify appsettings.json:

"TestConf": {
  "Test1": "foo",
  "test2": "bar"
}

Register a configuration in Program.cs:

builder.Services.Configure<TestConf>(builder.Configuration.GetSection(nameof(TestConf)));

And finally try somewhere to get options value:

[HttpGet("test")]
public async Task<IActionResult> TestAppsettingsForIssue([FromServices] IOptionsSnapshot<TestConf> testConf)
{
    var t = testConf.Value;
    return Ok();
}

I am not sure if this is a bug or intentional behavior.

Expected behavior

Since ASP.NET Core documentation says Configuration keys are case-insensitive it should not throw an error.

Actual behavior

It throws an error System.ArgumentException: Requested value 'test2' was not found.

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

Author:	mortifactor
Assignees:	-
Labels:	area-Extensions-Configuration
Milestone:	-