Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PGO: Assertion failed '(sizeDif == 4) || (sizeDif == 8)' #71217

Closed
EgorBo opened this issue Jun 23, 2022 · 2 comments · Fixed by #71306
Closed

PGO: Assertion failed '(sizeDif == 4) || (sizeDif == 8)' #71217

EgorBo opened this issue Jun 23, 2022 · 2 comments · Fixed by #71306
Assignees
@AndyAyersMS
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
7.0.0

Comments

@EgorBo
Copy link
Member

EgorBo commented Jun 23, 2022

Failed in various FullPGO outerloop pipelines, e.g. https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-70941-merge-715035df5abc46f3ad/Microsoft.VisualBasic.Core.Tests/1/console.b6d69b24.log?helixlogtype=result
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 23, 2022
@EgorBo EgorBo added this to the 7.0.0 milestone Jun 23, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jun 23, 2022
@ghost
Copy link

ghost commented Jun 23, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Failed in various FullPGO outerloop pipelines, e.g. https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-70941-merge-715035df5abc46f3ad/Microsoft.VisualBasic.Core.Tests/1/console.b6d69b24.log?helixlogtype=result

Author: EgorBo
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@JulieLeeMSFT JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label Jun 23, 2022
@AndyAyersMS
Copy link
Member

Looks like sizeDif is 0 here.

AndyAyersMS added a commit to AndyAyersMS/runtime that referenced this issue Jun 26, 2022
@AndyAyersMS
JIT: don't try to shorten an already short arm64 adr
cc08b00 
Fixes dotnet#71217.
@AndyAyersMS AndyAyersMS mentioned this issue Jun 26, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jun 26, 2022
AndyAyersMS added a commit that referenced this issue Jun 27, 2022
@AndyAyersMS
JIT: don't try to shorten an already short arm64 adr (#71306)
872fef0 
Fixes #71217.
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jun 27, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jul 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AndyAyersMS AndyAyersMS

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

JIT: don't try to shorten an already short arm64 adr AndyAyersMS/runtime
3 participants
@EgorBo @AndyAyersMS @JulieLeeMSFT