Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BEGIN_ILLINK_FEATURE_SWITCH mechanism for corelib.h does not work with nested classes #71847

Closed
AaronRobinsonMSFT opened this issue Jul 8, 2022 · 1 comment · Fixed by #105432
Closed

BEGIN_ILLINK_FEATURE_SWITCH mechanism for corelib.h does not work with nested classes #71847

AaronRobinsonMSFT opened this issue Jul 8, 2022 · 1 comment · Fixed by #105432
Labels
area-Interop-coreclr in-pr There is an active PR which will close this issue when it is merged linkable-framework Issues associated with delivering a linker friendly framework
Milestone
9.0.0

Comments

@AaronRobinsonMSFT
Copy link
Member

The following doesn't properly work when placed in the generated XML file:

DEFINE_CLASS(UTF8STRINGMARSHALLER_IN, Marshalling, Utf8StringMarshaller+ManagedToUnmanagedIn)

Following the Cecil syntax also fails:

DEFINE_CLASS(UTF8STRINGMARSHALLER_IN, Marshalling, Utf8StringMarshaller/ManagedToUnmanagedIn)
@AaronRobinsonMSFT AaronRobinsonMSFT added area-Interop-coreclr linkable-framework Issues associated with delivering a linker friendly framework labels Jul 8, 2022
@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 7.0.0 milestone Jul 8, 2022
@ghost
Copy link

ghost commented Jul 8, 2022

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr
See info in area-owners.md if you want to be subscribed.

Issue Details

The following doesn't properly work when placed in the generated XML file:

DEFINE_CLASS(UTF8STRINGMARSHALLER_IN, Marshalling, Utf8StringMarshaller+ManagedToUnmanagedIn)

Following the Cecil syntax also fails:

DEFINE_CLASS(UTF8STRINGMARSHALLER_IN, Marshalling, Utf8StringMarshaller/ManagedToUnmanagedIn)

Author: AaronRobinsonMSFT
Assignees: -
Labels:

area-Interop-coreclr, linkable-framework
Milestone: 7.0.0

@AaronRobinsonMSFT AaronRobinsonMSFT modified the milestones: 7.0.0, 8.0.0 Jul 15, 2022
@jkoritzinsky jkoritzinsky modified the milestones: 8.0.0, 9.0.0 Jul 19, 2023
jkoritzinsky added a commit to jkoritzinsky/runtime that referenced this issue Jul 24, 2024
@jkoritzinsky
Add support for nested types in the corelib.h parser for rooting de…
0f0fc2e 
…scriptors

Fixes dotnet#71847
@jkoritzinsky jkoritzinsky mentioned this issue Jul 24, 2024
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Jul 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Interop-coreclr in-pr There is an active PR which will close this issue when it is merged linkable-framework Issues associated with delivering a linker friendly framework
Projects
AppModel
Archived in project
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

Add support for nested types in the corelib.h parser for rooting descriptors jkoritzinsky/runtime
2 participants
@jkoritzinsky @AaronRobinsonMSFT