Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jitstress-isas-x86] Assertion failed 'compiler->compIsaSupportedDebugOnly(isa)' during 'Generate code' #71928

Closed
jakobbotsch opened this issue Jul 11, 2022 · 6 comments · Fixed by #72991
Closed

[jitstress-isas-x86] Assertion failed 'compiler->compIsaSupportedDebugOnly(isa)' during 'Generate code' #71928

jakobbotsch opened this issue Jul 11, 2022 · 6 comments · Fixed by #72991
Assignees
@tannergooding
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs
Milestone
7.0.0

Comments

@jakobbotsch
Copy link
Member

The jitstress-isas-x86 pipeline is frequently failing with this assertion failure in many tests.
Example pipeline run: https://dev.azure.com/dnceng/public/_build/results?buildId=1870359&view=results

Assert failure(PID 7472 [0x00001d30], Thread: 9756 [0x261c]): Assertion failed 'compiler->compIsaSupportedDebugOnly(isa)' in 'HillClimbing:Update(int,double,int):System.ValueTuple`2[Int32,Int32]:this' during 'Generate code' (IL size 1472; hash 0x27d1e134; FullOpts)
@jakobbotsch jakobbotsch changed the title [jitstress-isas-x86] Assertion failed 'compiler->compIsaSupportedDebugOnly(isa)' in 'JIT.HardwareIntrinsics.General.VectorBinaryOpTest__op_DivisionDouble:.ctor():this' during 'Generate code' [jitstress-isas-x86] Assertion failed 'compiler->compIsaSupportedDebugOnly(isa)' during 'Generate code' Jul 11, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jul 11, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 11, 2022
@ghost
Copy link

ghost commented Jul 11, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

The jitstress-isas-x86 pipeline is frequently failing with this assertion failure in many tests.
Example pipeline run: https://dev.azure.com/dnceng/public/_build/results?buildId=1870359&view=results

Assert failure(PID 7472 [0x00001d30], Thread: 9756 [0x261c]): Assertion failed 'compiler->compIsaSupportedDebugOnly(isa)' in 'HillClimbing:Update(int,double,int):System.ValueTuple`2[Int32,Int32]:this' during 'Generate code' (IL size 1472; hash 0x27d1e134; FullOpts)
Author: jakobbotsch
Assignees: -
Labels:

area-CodeGen-coreclr, untriaged
Milestone: -

@jakobbotsch
Copy link
Member Author

This is a relatively recent regression, the June 18th run does not have this problem while June 25th does.

@jakobbotsch
Copy link
Member Author

From a bisection this seems to be introduced/exposed by #69434. @tannergooding do you have an idea why that could cause this problem?

@tannergooding
Copy link
Member

I expect there is a mismatched check around the "baseline" ISAs (SSE/SSE2) and COMPlus_EnableSSE2=0 being set. Will take a look

@JulieLeeMSFT JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label Jul 11, 2022
@JulieLeeMSFT JulieLeeMSFT added this to the 7.0.0 milestone Jul 11, 2022
@JulieLeeMSFT
Copy link
Member

Same assertion in a different method.

Assert failure(PID 24198 [0x00005e86], Thread: 24198 [0x5e86]): Assertion failed 'compiler->compIsaSupportedDebugOnly(isa)' in 'JIT.HardwareIntrinsics.General.VectorBinaryOpTest__op_DivisionDouble:.ctor():this' during 'Generate code' (IL size 264; hash 0x7d5d7518; FullOpts)
Assert failure(PID 24236 [0x00005eac], Thread: 24236 [0x5eac]): Assertion failed 'compiler->compIsaSupportedDebugOnly(isa)' in 'JIT.HardwareIntrinsics.General.VectorBinaryOpTest__DivideDouble:.ctor():this' during 'Generate code' (IL size 264; hash 0x7c8af1a2; FullOpts)

@JulieLeeMSFT
Copy link
Member

runtime-coreclr jitstress-isas-x86 is constatnly failing.

image

@JulieLeeMSFT JulieLeeMSFT added the blocking-clean-ci-optional Blocking optional rolling runs label Jul 19, 2022
@runfoapp runfoapp bot mentioned this issue Jul 19, 2022
Closed
This was referenced Jul 21, 2022
Merged
Closed
jakobbotsch added a commit to jakobbotsch/runtime that referenced this issue Jul 28, 2022
@jakobbotsch
JIT: Skip Min/Max optimization when SSE2 is not enabled
3a6c92f 
Fix dotnet#71928
@jakobbotsch jakobbotsch mentioned this issue Jul 28, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 28, 2022
jakobbotsch added a commit that referenced this issue Jul 28, 2022
@jakobbotsch
JIT: Skip Min/Max optimization when SSE2 is not enabled (#72991)
e6723a3 
Fix #71928
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 28, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tannergooding tannergooding

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

JIT: Skip Min/Max optimization when SSE2 is not enabled jakobbotsch/runtime
3 participants
@jakobbotsch @tannergooding @JulieLeeMSFT