System.Diagnostics.DiagnosticSource: Activity with null operation name

[CodeBlanch]

Activity has a quirk in that its OperationName is not marked as nullable but its constructor allows it to be null. Chatted offline with the group CCed below and we agreed that it is a low-risk change to coalesce to string.Empty in this case.

Something like this:

        public Activity(string operationName)
        {
            Source = s_defaultSource;
            // Allow data by default in the constructor to keep the compatibility.
            IsAllDataRequested = true;

            if (string.IsNullOrEmpty(operationName))
            {
                NotifyError(new ArgumentException(SR.OperationNameInvalid)); // <- Note: Does not throw.
                operationName = string.Empty; // <- New logic here.
            }

            OperationName = operationName;
        }

We consider setting to something like "<null>" but decided to use string.Empty because that is similar to what happens for Activity.Source.Name in the case of legacy instances.

/cc @tarekgh @noahfalk @reyang @cijothomas @utpilla @alanwest

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[ghost]

Tagging subscribers to this area: @dotnet/area-system-diagnostics-activity
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Activity has a quirk in that its OperationName is not marked as nullable but its constructor allows it to be null. Chatted offline with the group CCed below and we agreed that it is a low-risk change to coalesce to string.Empty in this case.

Something like this:

        public Activity(string operationName)
        {
            Source = s_defaultSource;
            // Allow data by default in the constructor to keep the compatibility.
            IsAllDataRequested = true;

            if (string.IsNullOrEmpty(operationName))
            {
                NotifyError(new ArgumentException(SR.OperationNameInvalid)); // <- Note: Does not throw.
                operationName = string.Empty; // <- New logic here.
            }

            OperationName = operationName;
        }

We consider setting to something like "<null>" but decided to use string.Empty because that is similar to what happens for Activity.Source.Name in the case of legacy instances.

/cc @tarekgh @noahfalk @reyang @cijothomas @utpilla @alanwest

Author:	CodeBlanch
Assignees:	-
Labels:	area-System.Diagnostics.Activity
Milestone:	-