Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Activity.OperationName when Activity is created with null value #77746

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Nov 1, 2022

Fixes #77621

@ghost
Copy link

ghost commented Nov 1, 2022

Tagging subscribers to this area: @dotnet/area-system-diagnostics-activity
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #77621

Author: tarekgh
Assignees: -
Labels:

area-System.Diagnostics.Activity

Milestone: -

@tarekgh tarekgh added the breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. label Nov 1, 2022
@ghost ghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Nov 1, 2022
@ghost
Copy link

ghost commented Nov 1, 2022

Added needs-breaking-change-doc-created label because this PR has the breaking-change label.

When you commit this breaking change:

  1. Create and link to this PR and the issue a matching issue in the dotnet/docs repo using the breaking change documentation template, then remove this needs-breaking-change-doc-created label.
  2. Ask a committer to mail the .NET Breaking Change Notification DL.

Breaking change doc

Tagging @dotnet/compat for awareness of the breaking change.

@tarekgh tarekgh added this to the 8.0.0 milestone Nov 1, 2022
@tarekgh tarekgh requested a review from noahfalk November 1, 2022 20:26
@tarekgh
Copy link
Member Author

tarekgh commented Nov 1, 2022

CC @CodeBlanch

@tarekgh
Copy link
Member Author

tarekgh commented Nov 1, 2022

The failures in CI are not related.

@tarekgh tarekgh merged commit 4ad19b1 into dotnet:main Nov 1, 2022
@tarekgh tarekgh deleted the FixActivityNullOperationName branch November 1, 2022 22:53
@tarekgh tarekgh removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Nov 1, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Diagnostics.Activity breaking-change Issue or PR that represents a breaking API or functional change over a prerelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.Diagnostics.DiagnosticSource: Activity with null operation name
2 participants