Performance regression - Allocation/WorkingSet on PlaintextPlatform

[sebastienros]

Allocations are increasing significantly on PlaintextPlatform, Windows only.
Minimal commits range: 320f1e1...d47a24c

This type is the most allocating one after the regression shows up:

Name                                                                                               	Inc %	           Inc
 + System.Private.CoreLib.il!System.Threading.DeferredDisposableLifetime`1[System.__Canon].AddRef()	 82.8	   297,039,616
 |+ System.Private.CoreLib.il!ThreadPoolBoundHandle.AllocateNativeOverlapped                       	 82.8	   297,039,616
 | + System.Net.Sockets.il!SocketAsyncEventArgs.DoOperationReceiveSingleBuffer                     	 41.6	   149,219,392
 | + System.Net.Sockets.il!SocketAsyncEventArgs.DoOperationSendSingleBuffer                        	 39.2	   140,601,632

@stephentoub

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[sebastienros]

Not just Plaintext Platform actually, but most benchmarks that didn't allocate enough to even trigger a GC. All Windows.

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Allocations are increasing significantly on PlaintextPlatform, Windows only.
Minimal commits range: 320f1e1...d47a24c

This type is the most allocating one after the regression shows up:

Name                                                                                               	Inc %	           Inc
 + System.Private.CoreLib.il!System.Threading.DeferredDisposableLifetime`1[System.__Canon].AddRef()	 82.8	   297,039,616
 |+ System.Private.CoreLib.il!ThreadPoolBoundHandle.AllocateNativeOverlapped                       	 82.8	   297,039,616
 | + System.Net.Sockets.il!SocketAsyncEventArgs.DoOperationReceiveSingleBuffer                     	 41.6	   149,219,392
 | + System.Net.Sockets.il!SocketAsyncEventArgs.DoOperationSendSingleBuffer                        	 39.2	   140,601,632

@stephentoub

Author:	sebastienros
Assignees:	-
Labels:	area-System.Net.Sockets, tenet-performance, untriaged
Milestone:	-

[MihaZupan]

Looks like we're boxing the struct here

runtime/src/libraries/System.Private.CoreLib/src/System/Threading/DeferredDisposableLifetime.cs

Line 53 in c6045ad

ObjectDisposedException.ThrowIf(oldCount < 0, this);

regressed in #79096