Headers.TryAddWithoutValidation can still have side effects on the value

[blowdart]

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

When adding an authorization header with TryAddWithoutValidation() to test error handling the value is still trimmed, removing trailing spaces.

Expected Behavior

I would expect that the non-validating function would also not mutate the value in any way, adding without trimming.

This would of course be a breaking change, so I would suggest a new parameter,

public bool TryAddWithoutValidation (string name, string? value, bool leaveMyValueAloneDamnitIKnowWhatIAmDoing=false);

My naming may be a little long winded

Steps To Reproduce

string headerValue = string.Empty();

request.Headers.TryAddWithoutValidation(HeaderNames.Authorization, "Test + " " + headerValue);

// Now check the authorization header and its value will be "Test", not "Test " as expected

Exceptions (if any)

No response

.NET Version

6.0.12

Anything else?

No response

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

When adding an authorization header with TryAddWithoutValidation() to test error handling the value is still trimmed, removing trailing spaces.

Expected Behavior

I would expect that the non-validating function would also not mutate the value in any way, adding without trimming.

This would of course be a breaking change, so I would suggest a new parameter,

public bool TryAddWithoutValidation (string name, string? value, bool leaveMyValueAloneDamnitIKnowWhatIAmDoing=false);

My naming may be a little long winded

Steps To Reproduce

string headerValue = string.Empty();

request.Headers.TryAddWithoutValidation(HeaderNames.Authorization, "Test + " " + headerValue);

// Now check the authorization header and its value will be "Test", not "Test " as expected

Exceptions (if any)

No response

.NET Version

6.0.12

Anything else?

No response

Author:	blowdart
Assignees:	-
Labels:	area-System.Net.Http
Milestone:	-

[blowdart]

Doh never mind, it's on the incoming, darn Chris 😂