Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address NativeAOT header file strategy to allow windows global definitions to co-exist #81285

Closed
LakshanF opened this issue Jan 27, 2023 · 2 comments
Assignees
Milestone

Comments

@LakshanF
Copy link
Member

LakshanF commented Jan 27, 2023

It looks like in NativeAOT, if any file includes windows global definitions, then that file can't include PalRedhawkFunctions.h, to interact with the NativeAOT runtime.

For example, this can be seen on PalRedhawkMinWin.cpp, where the file includes #include <windows.h> but also needs to define its own PalEventWrite instead of using the one defined in PalRedhawkFunctions.h. This seems to be due to the fact that Windows and RedHawk global definitions cannot co-exist as the PalRedhawkMinWin.cpp comment states.

This issue is also going to exist in the planned EventPipe port to NativeAOT. Most of the files in the common EventPipe sources require windows global definitions and will not be able to use PalRedhawkFunctions.h and will need to define its own PalEventWrite similar to PalRedhawkMinWin.cpp above.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jan 27, 2023
@ghost
Copy link

ghost commented Jan 27, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

It looks like in NativeAOT, if any file includes windows global definitions, then

Author: LakshanF
Assignees: -
Labels:

area-NativeAOT-coreclr

Milestone: -

@LakshanF LakshanF self-assigned this Jan 27, 2023
@LakshanF LakshanF added this to the 8.0.0 milestone Jan 27, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Jan 27, 2023
@LakshanF
Copy link
Member Author

LakshanF commented Mar 2, 2023

Completed this as part of #80382 in the end.

@LakshanF LakshanF closed this as completed Mar 2, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant