Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.0] System.Net.Http.Json nuget issue in allconfigurations #81914

Closed
carlossanlop opened this issue Feb 9, 2023 · 6 comments
Closed

[7.0] System.Net.Http.Json nuget issue in allconfigurations #81914

carlossanlop opened this issue Feb 9, 2023 · 6 comments
Assignees
Labels
area-Infrastructure-libraries Known Build Error Use this to report build issues in the .NET Helix tab

Comments

@carlossanlop
Copy link
Member

carlossanlop commented Feb 9, 2023

After merging this backport PR: #80553

I looked at the public rolling builds for 7.0 and noticed a windows all-configurations failure related to the nuget package System.Net.Http.Json, which unfortunately did not show up in the PR CI.

artifacts\bin\testPackages\projects\System.Net.Http.Json\project.csproj(0,0): error NU1102: (NETCORE_ENGINEERING_TELEMETRY=Build) Unable to find package System.Text.Json with version (>= 7.0.2)
  - Found 1560 version(s) in dotnet7 [ Nearest version: 7.0.0-rtm.22511.4 ]
  - Found 98 version(s) in dotnet-public [ Nearest version: 7.0.1 ]
  - Found 1 version(s) in dotnet-eng [ Nearest version: 5.0.0-alpha.1.19618.1 ]
  - Found 1 version(s) in dotnet7-transport [ Nearest version: 7.0.0-rc.1.22426.10 ]
  - Found 0 version(s) in D:\a\_work\1\s\artifacts\packages\Release\
  - Found 0 version(s) in richnav
  - Found 0 version(s) in darc-pub-dotnet-emsdk-ba16583
  - Found 0 version(s) in dotnet-libraries
  - Found 0 version(s) in dotnet-tools

Looking at the System.Net.Http.Json.csproj change history, I see that the above PR was the first one to modify the project, so the OOB changes look right (version 1 bump): https://github.com/dotnet/runtime/commits/release/7.0/src/libraries/System.Net.Http.Json/src/System.Net.Http.Json.csproj

Since the error is complaining about System.Text.Json specifically, I checked its change history too, and the last time it was modified was in the branding PR from a couple days ago, which simply turned off the GeneratePackageOnBuild property, but the servicing version remains as 2: e35c90f

I am not sure I understand the reason for the complaint. @ViktorHofer @ericstj any ideas?

{
  "ErrorMessage": "Unable to find package System.Text.Json with version (>= 7.0.2)",
  "BuildRetry": false,
  "ErrorPattern": "",
  "ExcludeConsoleLog": false
}

Report

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 0 0
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Feb 9, 2023
@ghost
Copy link

ghost commented Feb 9, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

After merging this backport PR: #80553

I looked at the public rolling builds for 7.0 and noticed a windows all-configurations failure related to the nuget package System.Net.Http.Json, which unfortunately did not show up in the PR CI.

artifacts\bin\testPackages\projects\System.Net.Http.Json\project.csproj(0,0): error NU1102: (NETCORE_ENGINEERING_TELEMETRY=Build) Unable to find package System.Text.Json with version (>= 7.0.2)
  - Found 1560 version(s) in dotnet7 [ Nearest version: 7.0.0-rtm.22511.4 ]
  - Found 98 version(s) in dotnet-public [ Nearest version: 7.0.1 ]
  - Found 1 version(s) in dotnet-eng [ Nearest version: 5.0.0-alpha.1.19618.1 ]
  - Found 1 version(s) in dotnet7-transport [ Nearest version: 7.0.0-rc.1.22426.10 ]
  - Found 0 version(s) in D:\a\_work\1\s\artifacts\packages\Release\
  - Found 0 version(s) in richnav
  - Found 0 version(s) in darc-pub-dotnet-emsdk-ba16583
  - Found 0 version(s) in dotnet-libraries
  - Found 0 version(s) in dotnet-tools

Looking at the System.Net.Http.Json.csproj change history, I see that the above PR was the first one to modify the project, so the OOB changes look right (version 1 bump): https://github.com/dotnet/runtime/commits/release/7.0/src/libraries/System.Net.Http.Json/src/System.Net.Http.Json.csproj

Since the error is complaining about System.Text.Json specifically, I checked its change history too, and the last time it was modified was in the branding PR from a couple days ago, which simply turned off the GeneratePackageOnBuild property, but the servicing version remains as 2: e35c90f

I am not sure I understand the reason for the complaint. @ViktorHofer @ericstj any ideas?

Author: carlossanlop
Assignees: carlossanlop, ManickaP, MihaZupan
Labels:

area-Infrastructure-libraries

Milestone: -

@carlossanlop
Copy link
Member Author

I think I know what the problem is. The System.Text.Json nuget package was never pushed from the last release: https://www.nuget.org/packages/System.Text.Json#versions-body-tab

The last version available in nuget.org is 7.0.1. The error above is asking for 7.0.2.

@rbhanda @mmitche can one of you help push the 7.0.2. nuget package we generated in the February Release?

@MihaZupan
Copy link
Member

MihaZupan commented Feb 9, 2023

My guess would be that the 7.0.2 version of System.Text.Json isn't on our engineering nuget feeds. I'll ping engineering.

Ah, it's not even on NuGet :)

@carlossanlop carlossanlop removed the untriaged New issue has not been triaged by the area owner label Feb 9, 2023
@carlossanlop carlossanlop assigned rbhanda and unassigned ManickaP, MihaZupan and rbhanda Feb 9, 2023
@carlossanlop
Copy link
Member Author

So we can't push it yet because GA day for the February Release is 2/14. We're discussing workarounds.

@lewing
Copy link
Member

lewing commented Mar 3, 2023

is this fixed then?

@ViktorHofer
Copy link
Member

Yes this is already fixed. The package is on nuget.org and on our feeds.

@ghost ghost locked as resolved and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-libraries Known Build Error Use this to report build issues in the .NET Helix tab
Projects
None yet
Development

No branches or pull requests

6 participants