-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.0] System.Net.Http.Json nuget issue in allconfigurations #81914
Comments
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsAfter merging this backport PR: #80553 I looked at the public rolling builds for 7.0 and noticed a windows all-configurations failure related to the nuget package System.Net.Http.Json, which unfortunately did not show up in the PR CI.
Looking at the System.Net.Http.Json.csproj change history, I see that the above PR was the first one to modify the project, so the OOB changes look right (version 1 bump): https://github.com/dotnet/runtime/commits/release/7.0/src/libraries/System.Net.Http.Json/src/System.Net.Http.Json.csproj Since the error is complaining about System.Text.Json specifically, I checked its change history too, and the last time it was modified was in the branding PR from a couple days ago, which simply turned off the GeneratePackageOnBuild property, but the servicing version remains as 2: e35c90f I am not sure I understand the reason for the complaint. @ViktorHofer @ericstj any ideas?
|
I think I know what the problem is. The System.Text.Json nuget package was never pushed from the last release: https://www.nuget.org/packages/System.Text.Json#versions-body-tab The last version available in nuget.org is 7.0.1. The error above is asking for 7.0.2. @rbhanda @mmitche can one of you help push the 7.0.2. nuget package we generated in the February Release? |
My guess would be that the 7.0.2 version of System.Text.Json isn't on our engineering nuget feeds. I'll ping engineering. Ah, it's not even on NuGet :) |
So we can't push it yet because GA day for the February Release is 2/14. We're discussing workarounds. |
is this fixed then? |
Yes this is already fixed. The package is on nuget.org and on our feeds. |
After merging this backport PR: #80553
I looked at the public rolling builds for 7.0 and noticed a windows all-configurations failure related to the nuget package System.Net.Http.Json, which unfortunately did not show up in the PR CI.
Libraries Build windows allConfigurations x64 Release
Looking at the System.Net.Http.Json.csproj change history, I see that the above PR was the first one to modify the project, so the OOB changes look right (version 1 bump): https://github.com/dotnet/runtime/commits/release/7.0/src/libraries/System.Net.Http.Json/src/System.Net.Http.Json.csproj
Since the error is complaining about System.Text.Json specifically, I checked its change history too, and the last time it was modified was in the branding PR from a couple days ago, which simply turned off the GeneratePackageOnBuild property, but the servicing version remains as 2: e35c90f
I am not sure I understand the reason for the complaint. @ViktorHofer @ericstj any ideas?
Report
Summary
The text was updated successfully, but these errors were encountered: