Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable TFM filtering for runtime's source-build #82298

Closed
oleksandr-didyk opened this issue Feb 17, 2023 · 2 comments
Closed

Enable TFM filtering for runtime's source-build #82298

oleksandr-didyk opened this issue Feb 17, 2023 · 2 comments

Comments

@oleksandr-didyk
Copy link
Contributor

Created based on #81468 (comment)

Based on the linked comment / discussion in the issue, TFM filtering should be enabled for runtime's source-build once other repositories have the filtering enabled and working as not to cause issue downstream.

The exact approach should be discussed once the work on the issue can start. At the moment of writing, there are two approaches:

  • utilize the existing runtime's tooling for filtering out TFMs
  • utilize the newly introduced logic to Arcade infra

The source-build team would prefer the second approach due to other repos also utilizing it instead of introducing a special case for runtime that potentially could increase maintenance work down the line.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 17, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Feb 17, 2023
@ghost
Copy link

ghost commented Feb 17, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Created based on #81468 (comment)

Based on the linked comment / discussion in the issue, TFM filtering should be enabled for runtime's source-build once other repositories have the filtering enabled and working as not to cause issue downstream.

The exact approach should be discussed once the work on the issue can start. At the moment of writing, there are two approaches:

  • utilize the existing runtime's tooling for filtering out TFMs
  • utilize the newly introduced logic to Arcade infra

The source-build team would prefer the second approach due to other repos also utilizing it instead of introducing a special case for runtime that potentially could increase maintenance work down the line.

Author: oleksandr-didyk
Assignees: -
Labels:

area-Infrastructure-libraries, untriaged, needs-area-label

Milestone: -

@jkotas jkotas removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 17, 2023
@ViktorHofer ViktorHofer added this to the 8.0.0 milestone Mar 6, 2023
@ViktorHofer ViktorHofer removed the untriaged New issue has not been triaged by the area owner label Mar 6, 2023
@ViktorHofer
Copy link
Member

This is already implemented.

@ghost ghost locked as resolved and limited conversation to collaborators Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants