add source-build pre-built detection #82300
Conversation
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsResolves In progress of being added to SBRP:
Allowed pre-builts:
Using old intermediates:
|
| @@ -38,6 +38,7 @@ | |||
| <InnerBuildArgs>$(InnerBuildArgs) --nodereuse false</InnerBuildArgs> | |||
| <InnerBuildArgs>$(InnerBuildArgs) --warnAsError false</InnerBuildArgs> | |||
| <InnerBuildArgs>$(InnerBuildArgs) --outputrid $(TargetRid)</InnerBuildArgs> | |||
| <InnerBuildArgs>$(InnerBuildArgs) /p:ArcadeBuildFromSource=true</InnerBuildArgs> | |||
There was a problem hiding this comment.
Why is this being specified. This does not seem correct. Only ArcadeInnerBuildFromSource=true should be used in this context.
There was a problem hiding this comment.
Due to runtime overriding BaseInnerSourceBuildCommand in SourceBuild.props. This is the issue we talked about in the beginning of this work, when runtime's inner build would not restore intermediate packages
| @@ -16,6 +16,7 @@ | |||
| <add key="dotnet-tools" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json" /> | |||
| <add key="dotnet-eng" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json" /> | |||
| <add key="dotnet-libraries" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-libraries/nuget/v3/index.json" /> | |||
| <add key="dotnet-libraries-transport" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-libraries-transport/nuget/v3/index.json" /> | |||
There was a problem hiding this comment.
For System.CommandLine source-build intermediate
ghost
closed this
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
ghost
locked as resolved and limited conversation to collaborators
Resolves
In progress of being added to SBRP:
Microsoft.CodeAnalysis 4.4.0Microsoft.Build 17.3.2Microsoft.Extensions.DependencyModel 6.0.0System.Reflection.Metadata 6.0.1-> add System.Reflection.Metadata 6.0.1 source-build-reference-packages#506Allowed pre-builts:
Microsoft.NETCore.App.Crossgen2andMicrosoft.NETCore.App.Runtime-> Dealing with pre-builts brought in by SDK bundled versions in repo source-build source-build#3228Microsoft.NETFramework.ReferenceAssemblies-> Enable TFM filtering for runtime's source-build #82298Using old intermediates:
System.CommandLine 2.0.0-beta4.22355.1-> see discussion in Enable source-build pre-built detection #81468