-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add System.Reflection.Metadata 6.0.1 #506
Merged
MichaelSimons
merged 3 commits into
dotnet:main
from
oleksandr-didyk:add-reflection-metadata-6-0-1
Feb 2, 2023
Merged
add System.Reflection.Metadata 6.0.1 #506
MichaelSimons
merged 3 commits into
dotnet:main
from
oleksandr-didyk:add-reflection-metadata-6-0-1
Feb 2, 2023
+7,332
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandr-didyk
requested review from
MichaelSimons,
crummel and
lbussell
as code owners
February 1, 2023 13:54
General comments:
|
I forgot one more thing:
|
|
Merged
Regarding #4, once you complete the changes to enable prebuilt detection for runtime, it would be good to validate in a full source-build. After validating that, it would be good to enable the per-repo pvp flow for runtime to validate it works and then this SBRP will get referenced. |
MichaelSimons
approved these changes
Feb 2, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done as part of dotnet/runtime#81468
runtime
is manually enforcing the patched 6.0.1 version throughVersions.props
as part of dotnet/runtime#73871