Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SBRP] generate.sh doesn't handle "<icon>" in reference package nuspecs #1957

Closed
dagood opened this issue Dec 22, 2020 · 3 comments · Fixed by dotnet/source-build-reference-packages#514
Closed

[SBRP] generate.sh doesn't handle "<icon>" in reference package nuspecs #1957

dagood opened this issue Dec 22, 2020 · 3 comments · Fixed by dotnet/source-build-reference-packages#514
Assignees
@oleksandr-didyk
Labels
area-sbrp Source build reference packages

Comments

@dagood
Copy link
Member

dagood commented Dec 22, 2020

The tooling generated some nuspecs with <icon>Icon.png</icon>, but without placing the file. It should either point at a central file (avoid many duplicates of the same file) or remove the icon because we don't need it in this context.
@dagood dagood added the area-infra Source-build infrastructure and reporting label Dec 22, 2020
@dagood dagood mentioned this issue Dec 22, 2020
Merged
@dseefeld dseefeld self-assigned this Jan 7, 2021
@MichaelSimons MichaelSimons added area-arcade Common Arcade source-build infra and removed area-infra Source-build infrastructure and reporting labels Oct 20, 2022
@MichaelSimons MichaelSimons changed the title dotnet-source-build-utilities doesn't handle "<icon>" in reference package nuspecs [SBRP] generate.sh doesn't handle "<icon>" in reference package nuspecs Oct 20, 2022
@crummel crummel mentioned this issue Oct 27, 2022
Closed
@tkapin tkapin added the area-product-experience Improvements in the end-user's product experience label Feb 1, 2023
@tkapin
Copy link
Member

tkapin commented Feb 1, 2023

@MichaelSimons - I've added area-product-experience label to this based on our recent conversation. Please feel free to remove it if you think it shouldn't be labeled so.

@MichaelSimons MichaelSimons added area-sbrp Source build reference packages and removed area-product-experience Improvements in the end-user's product experience area-arcade Common Arcade source-build infra labels Feb 1, 2023
@MichaelSimons
Copy link
Member

Just like the runtime repo - we only allow one area per issue. This really is an sbrp issue so I assigned it to area-sbrp. The area-product-experience is intended for the source-build product experience.

@tkapin
Copy link
Member

tkapin commented Feb 1, 2023

Ah, I wasn't aware there is only one area permitted. Thanks for explanation.

@MichaelSimons MichaelSimons mentioned this issue Feb 1, 2023
Merged
@oleksandr-didyk oleksandr-didyk self-assigned this Feb 7, 2023
@oleksandr-didyk oleksandr-didyk mentioned this issue Feb 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleksandr-didyk oleksandr-didyk

Labels
area-sbrp Source build reference packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove icons from nuspec files oleksandr-didyk/source-build-reference-packages
5 participants
@dseefeld @MichaelSimons @dagood @tkapin @oleksandr-didyk