Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser][icu] Find a way to test ICU sharding on Node #82593

Closed
ilonatommy opened this issue Feb 24, 2023 · 1 comment
Closed

[browser][icu] Find a way to test ICU sharding on Node #82593

ilonatommy opened this issue Feb 24, 2023 · 1 comment
Assignees
@ilonatommy
Labels
area-VM-meta-mono
Milestone
Future

Comments

@ilonatommy
Copy link
Member

In #80421 we did not add tests for NodeJS for the case of automatic shard selection based on the environment locale. On Windows, because it is hard to change language programistically and most probably we would need to have a special machine with different locale set. On Linux, because we are relying on MsBuild to run WBT and MsBuild is changing the locale to en_US.UTF-8, regardless of our settings. We could try to find a workaround.
@ilonatommy ilonatommy self-assigned this Feb 24, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Feb 24, 2023
@marek-safar marek-safar removed the untriaged New issue has not been triaged by the area owner label Jul 21, 2023
@marek-safar marek-safar added this to the Future milestone Jul 21, 2023
@ilonatommy
Copy link
Member Author

closing with #108582

@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ilonatommy ilonatommy

Labels
area-VM-meta-mono
Projects
None yet
Milestone
Future
Development

No branches or pull requests
3 participants
@marek-safar @jeffschwMSFT @ilonatommy