Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][icu] ICU files sharding + custom icu data loading for WASM #80421

Merged
merged 79 commits into from
Feb 24, 2023

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Jan 10, 2023

  • Allows choosing ICU file in .csproj, including custom ICU files.
  • Adds an instruction how to build custom ICU.
  • Works only for Wasm Console / Wasm Browser. Blazor is not touched and setting any of the new flags does not have any effect on Blazor - tested on the aspnetcore's sample.
  • We have no tests for NodeJS under Windows because it's hard to change locale in Windows only for test purposes. We do not have them under Linux because helix is using MsBuild for building WBT and MsBuild is automatically overwriting any locale settings we try to force. Manual test pass.

Future work:

  • Automatic tools for creating custom icu pack, so that manual running of icu build would not be necessary.

@ghost
Copy link

ghost commented Jan 10, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm

Milestone: 8.0.0

@ilonatommy ilonatommy changed the title [was, [wasm][icu] ICU files sharding + custom icu data loading for WASM Jan 10, 2023
@ilonatommy ilonatommy marked this pull request as draft January 10, 2023 10:36
@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Feb 23, 2023
@ilonatommy
Copy link
Member Author

ilonatommy commented Feb 23, 2023

How can it fail when my branch does not even have this file?

@azure-pipelinesazure-pipelines
/ dotnet-linker-tests (Build browser-wasm linux release Runtime_Release)
src/tasks/WasmAppBuilder/wasi/WasiAppBuilder.cs#L20
src/tasks/WasmAppBuilder/wasi/WasiAppBuilder.cs(20,61): error CS0103: (NETCORE_ENGINEERING_TELEMETRY=Build) The name 'IcuDataFileName' does not exist in the current context

https://github.com/ilonatommy/runtime/tree/wasm-browser-basic-sharding/src/tasks/WasmAppBuilder/wasi
image

edit:
it's because CI is merging main to the PR's branch and then building the result, that explains the error.

@radical radical self-requested a review February 23, 2023 20:25
@radical
Copy link
Member

radical commented Feb 23, 2023

/azp run runtime-wasm-optional

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@radical radical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a lot of work! Thank you, and excellent job! 👍

@ilonatommy
Copy link
Member Author

/azp run runtime-wasm-non-libtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy
Copy link
Member Author

/azp run runtime-wasm-optional

The failures

src/libraries/Common/tests/System/TestILAssembly/TestILAssembly.ilproj(0,0): error NU1101: (NETCORE_ENGINEERING_TELEMETRY=Restore) Unable to find package runtime.wasi-x64.microsoft.netcore.ilasm. No packages exist with this id in source(s): dotnet-eng, dotnet-libraries, dotnet-public, dotnet-tools, dotnet7, dotnet7-transport, dotnet8, dotnet8-transport

are not connected.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants