Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser][icu] Automate custom icu creation #82908

Open
ilonatommy opened this issue Mar 2, 2023 · 1 comment
Open

[browser][icu] Automate custom icu creation #82908

ilonatommy opened this issue Mar 2, 2023 · 1 comment
Assignees
Labels
arch-wasm WebAssembly architecture area-System.Globalization packaging Related to packaging
Milestone

Comments

@ilonatommy
Copy link
Member

ilonatommy commented Mar 2, 2023

In #80421 and #83585 we enabled loading custom ICU by setting <WasmIcuDataFileName> build property. Customers, in order to create such a custom ICU have to:

  1. clone the icu repo,
  2. install all the required tools,
  3. edit manually the ICU filters,
  4. build.

If they use Codespaces they need only steps 3-4 but actually manual edition of filters is the step that is the most error-prone. We would like to make this process easier for them by e.g. creating a dotnet tool.

Tool's input arguments:

  • locales - a list of locales that ICU should support,
  • outputPath - output path for the resulting ICU.
  • target - browser / mobile / wasi

Tool's output:

  • *.dat file created in outputPath location.

The tool would create a custom filter based on the locales passed and then trigger the build process.

Future work to be considered:

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture packaging Related to packaging labels Mar 2, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Mar 2, 2023
@ghost
Copy link

ghost commented Mar 2, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

In #80421 we enabled loading custom ICU by setting <WasmIcuDataFileName> build property. Customers, in order to create such a custom ICU have to:

  1. clone the icu repo,
  2. install all the required tools,
  3. edit manually the ICU filters,
  4. build.

If they use Codespaces they need only steps 3-4 but actually manual edition of filters is the step that is the most error-prone. We would like to make this process easier for them by e.g. creating a dotnet tool.

Tool's input arguments:

  • locales - a list of locales that ICU should support,
  • outputPath - output path for the resulting ICU.
  • target - browser / mobile / wasi

Tool's output:

  • *.dat file created in outputPath location.

The tool would create a custom filter based on the locales passed and then trigger the build process.

Author: ilonatommy
Assignees: directhex, steveisok, ilonatommy
Labels:

arch-wasm, packaging

Milestone: -

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-wasm WebAssembly architecture area-System.Globalization packaging Related to packaging
Projects
None yet
Development

No branches or pull requests

5 participants