Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

baseservices/threading/regressions/beta1/347011/347011.dll test failed #83929

Closed
EgorBo opened this issue Mar 25, 2023 · 2 comments · Fixed by #83931
Closed

baseservices/threading/regressions/beta1/347011/347011.dll test failed #83929

EgorBo opened this issue Mar 25, 2023 · 2 comments · Fixed by #83931
Labels
area-System.DateTime
Milestone
8.0.0

Comments

@EgorBo
Copy link
Member

EgorBo commented Mar 25, 2023 

Assert.Equal() Failure
Expected: 100
Actual:   -5

https://dev.azure.com/dnceng-public/public/_build/results?buildId=217500&view=ms.vss-test-web.build-test-results-tab&runId=4064634&resultId=108726&paneView=debug

Looks like caused by #83604 @tarekgh
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Mar 25, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 25, 2023
@EgorBo EgorBo mentioned this issue Mar 25, 2023
Merged
@EgorBo
Copy link
Member Author

EgorBo commented Mar 25, 2023

I assume it was an intentional change to stop throwing ODE in Timer.Change as per #83604 (comment)
so presumably we only need to update this test?

jkotas added a commit to jkotas/runtime that referenced this issue Mar 25, 2023
@jkotas
Delete redundant test
a3391ea 
This scenario has comprehensive test coverage under src/libraries

Fixes dotnet#83929
@jkotas jkotas mentioned this issue Mar 25, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Mar 25, 2023
@tarekgh
Copy link
Member

tarekgh commented Mar 26, 2023

I assume it was an intentional change to stop throwing ODE in Timer.Change as per #83604 (comment)

Yes, this was an intentional change.

@tarekgh tarekgh added this to the 8.0.0 milestone Mar 26, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Mar 26, 2023
@tarekgh tarekgh removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 26, 2023
jkotas added a commit that referenced this issue Mar 26, 2023
@jkotas
Delete redundant test (#83931)
95dbfc2 
This scenario has comprehensive test coverage under src/libraries

Fixes #83929
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Mar 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.DateTime
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Delete redundant test jkotas/runtime
2 participants
@EgorBo @tarekgh