Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine behavior for GeneratedComClass on a type with no GeneratedComInterface interfaces #84032

Closed
jkoritzinsky opened this issue Mar 28, 2023 · 3 comments
Closed

Determine behavior for GeneratedComClass on a type with no GeneratedComInterface interfaces #84032

jkoritzinsky opened this issue Mar 28, 2023 · 3 comments
Labels
area-System.Runtime.InteropServices
Milestone
8.0.0

Comments

@jkoritzinsky
Copy link
Member

Do we want to warn / bail if there are no interfaces with GeneratedComInterface on a GeneratedComClass type?

Originally posted by @elinor-fung in #83755 (comment)
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Mar 28, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 28, 2023
@vcsjones vcsjones added area-System.Runtime.InteropServices and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Mar 28, 2023
@ghost
Copy link

ghost commented Mar 28, 2023

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Do we want to warn / bail if there are no interfaces with GeneratedComInterface on a GeneratedComClass type?

Originally posted by @elinor-fung in #83755 (comment)

Author: jkoritzinsky
Assignees: -
Labels:

area-System.Runtime.InteropServices, untriaged
Milestone: -

@AaronRobinsonMSFT AaronRobinsonMSFT removed the untriaged New issue has not been triaged by the area owner label May 1, 2023
@AaronRobinsonMSFT AaronRobinsonMSFT added this to the Future milestone May 1, 2023
@AaronRobinsonMSFT
Copy link
Member

Since the primary focus for the COM source generator in .NET 8 is for our first party teams, we can go with the yes and then relax it in the future if needed.

@AaronRobinsonMSFT AaronRobinsonMSFT modified the milestones: Future, 8.0.0 May 1, 2023
@jkoritzinsky
Copy link
Member Author

Completed with #87436

@ghost ghost locked as resolved and limited conversation to collaborators Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Runtime.InteropServices
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
3 participants
@vcsjones @jkoritzinsky @AaronRobinsonMSFT