Provide support for exposing .NET classes to COM through source generation #83755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoritzinsky
added
area-System.Runtime.InteropServices
source-generator
jkoritzinsky
requested review from
AaronRobinsonMSFT,
jtschuster and
elinor-fung
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsImplement the API defined in #83471 in Ancillary.Interop.
|
…eed in the tests.
src/libraries/System.Runtime.InteropServices/tests/Ancillary.Interop/IComExposedDetails.cs
Show resolved
Hide resolved
...libraries/System.Runtime.InteropServices/tests/Ancillary.Interop/StrategyBasedComWrappers.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/ComClassGenerator.cs
Show resolved
Hide resolved
src/libraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/ComClassGenerator.cs
Outdated
Show resolved
Hide resolved
…rmation type instead of the user type. This allows the generator to be more incremental as the class-info type now doesn't need the class name (so a class rename will not result in regenerating the syntax for this step).
AaronRobinsonMSFT
approved these changes
Mar 27, 2023
...libraries/System.Runtime.InteropServices/tests/Ancillary.Interop/IUnknownDerivedAttribute.cs
Outdated
Show resolved
Hide resolved
...libraries/System.Runtime.InteropServices/tests/Ancillary.Interop/IUnknownDerivedAttribute.cs
Outdated
Show resolved
Hide resolved
elinor-fung
approved these changes
Mar 27, 2023
...libraries/System.Runtime.InteropServices/tests/Ancillary.Interop/ComExposedClassAttribute.cs
Outdated
Show resolved
Hide resolved
...braries/System.Runtime.InteropServices/tests/Ancillary.Interop/GeneratedComClassAttribute.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/ComClassGenerator.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/ComClassGenerator.cs
Outdated
Show resolved
Hide resolved
| names.Add(iface.ToDisplayString()); | ||
| } | ||
| } | ||
| return new ComClassInfo( |
There was a problem hiding this comment.
Do we want to warn / bail if there are no interfaces with GeneratedComInterface?
There was a problem hiding this comment.
I think that's still a valid scenario, but I could see us adding a warning for it. I'll file a follow-up issue for that.
| { | ||
| } | ||
|
|
||
| public unsafe class GeneratedComClassTests |
There was a problem hiding this comment.
Is the plan to add some of the more complex cases (at least the ones in the ComObjectRedux repo) in a follow-up change?
There was a problem hiding this comment.
Yes, I'll add those in in a follow-up change.
|
Uncategorized failures were #84010 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the API defined in #83471 in Ancillary.Interop and add a source generator in ComInterfaceGenerator to provide the expected behavior.