Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regressions in System.Reflection.Invoke #84789

Closed
performanceautofiler bot opened this issue Mar 30, 2023 · 2 comments
Closed

Regressions in System.Reflection.Invoke #84789

performanceautofiler bot opened this issue Mar 30, 2023 · 2 comments
Labels
arch-arm64 area-System.Reflection os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Mar 30, 2023

Run Information

Name Value
Architecture arm64
OS ubuntu 20.04
Queue AmpereUbuntu
Baseline 605eb6eda2b1e04f79a2f7937506cd9deaec6a9b
Compare c22b79ae2d1b2a9ca73a42e246e3f3da02e631fe
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Reflection.Invoke

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
Field_Get_int - Duration of single invocation 74.83 ns 93.81 ns 1.25 0.28 False

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

Payloads

Baseline
Compare

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Reflection.Invoke*'

Payloads

Baseline
Compare

Histogram

System.Reflection.Invoke.Field_Get_int


Description of detection logic

IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 93.8067525548623 > 78.1986461298077.
IsChangePoint: Marked as a change because one of 1/13/2023 9:23:19 AM, 3/17/2023 5:40:49 AM, 3/25/2023 12:18:49 AM, 3/30/2023 4:24:24 AM falls between 3/21/2023 2:53:21 PM and 3/30/2023 4:24:24 AM.
IsRegressionStdDev: Marked as regression because -24.345292438042073 (T) = (0 -92.92124544278508) / Math.Sqrt((0.4761242123680715 / (22)) + (9.688559887847028 / (17))) is less than -2.026192463026769 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (22) + (17) - 2, .025) and -0.252365131071706 = (74.19660859071358 - 92.92124544278508) / 74.19660859071358 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository


Run Information

Name Value
Architecture arm64
OS ubuntu 20.04
Queue AmpereUbuntu
Baseline 605eb6eda2b1e04f79a2f7937506cd9deaec6a9b
Compare c22b79ae2d1b2a9ca73a42e246e3f3da02e631fe
Diff Diff
Configs CompilationMode:tiered, RunKind:micro
@performanceautofiler performanceautofiler bot added arch-arm64 os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime untriaged New issue has not been triaged by the area owner labels Mar 30, 2023
@AndyAyersMS
Copy link
Member

Reflection invoke looks like a regression, might be #83484

@AndyAyersMS AndyAyersMS removed the untriaged New issue has not been triaged by the area owner label Mar 30, 2023
@AndyAyersMS
Copy link
Member

newplot - 2023-04-13T094110 608

Regression has persisted, so looks to be real.

@AndyAyersMS AndyAyersMS transferred this issue from dotnet/perf-autofiling-issues Apr 13, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 13, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Apr 13, 2023
@AndyAyersMS AndyAyersMS changed the title [Perf] Linux/arm64: 2 Regressions on 3/25/2023 3:46:49 AM Regressions in System.Reflection.Invoke Apr 13, 2023
AndyAyersMS added a commit to AndyAyersMS/runtime that referenced this issue Apr 14, 2023
The initial version of this only really worked for very simple cases.
Generalize to handle loops with multiple exits better.

The rough idea is to compute how much additional profile flow needs
to come out of the loop to match the capped probability, and then
try and find one exit block where we can adjust likelhoods to cause
exactly this amount of extra flow to leave the loop.

Closes dotnet#84789.
@ghost ghost added in-pr There is an active PR which will close this issue when it is merged and removed in-pr There is an active PR which will close this issue when it is merged labels Apr 14, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Apr 14, 2023
@teo-tsirpanis teo-tsirpanis added area-System.Reflection and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Apr 30, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-arm64 area-System.Reflection os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime
Projects
None yet
Development

No branches or pull requests

3 participants