-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regressions in System.Reflection.Invoke #84789
Labels
arch-arm64
area-System.Reflection
os-linux
Linux OS (any supported distro)
runtime-coreclr
specific to the CoreCLR runtime
Comments
performanceautofiler
bot
added
arch-arm64
os-linux
Linux OS (any supported distro)
runtime-coreclr
specific to the CoreCLR runtime
untriaged
New issue has not been triaged by the area owner
labels
Mar 30, 2023
Reflection invoke looks like a regression, might be #83484 |
AndyAyersMS
removed
the
untriaged
New issue has not been triaged by the area owner
label
Mar 30, 2023
dotnet-issue-labeler
bot
added
the
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
Apr 13, 2023
AndyAyersMS
changed the title
[Perf] Linux/arm64: 2 Regressions on 3/25/2023 3:46:49 AM
Regressions in System.Reflection.Invoke
Apr 13, 2023
AndyAyersMS
added a commit
to AndyAyersMS/runtime
that referenced
this issue
Apr 14, 2023
The initial version of this only really worked for very simple cases. Generalize to handle loops with multiple exits better. The rough idea is to compute how much additional profile flow needs to come out of the loop to match the capped probability, and then try and find one exit block where we can adjust likelhoods to cause exactly this amount of extra flow to leave the loop. Closes dotnet#84789.
ghost
added
in-pr
There is an active PR which will close this issue when it is merged
and removed
in-pr
There is an active PR which will close this issue when it is merged
labels
Apr 14, 2023
teo-tsirpanis
added
area-System.Reflection
and removed
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
Apr 30, 2023
ghost
locked as resolved and limited conversation to collaborators
May 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
arch-arm64
area-System.Reflection
os-linux
Linux OS (any supported distro)
runtime-coreclr
specific to the CoreCLR runtime
Run Information
Regressions in System.Reflection.Invoke
Test Report
Repro
General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md
Payloads
Baseline
Compare
Payloads
Baseline
Compare
Histogram
System.Reflection.Invoke.Field_Get_int
Description of detection logic
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
Run Information
The text was updated successfully, but these errors were encountered: