Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] System.Collections.Immutable.Tests+AOT failing on rolling builds #85012

Closed
radical opened this issue Apr 18, 2023 · 3 comments
Closed
Assignees
Labels
arch-wasm WebAssembly architecture area-Codegen-AOT-mono blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' test-failure
Milestone

Comments

@radical
Copy link
Member

radical commented Apr 18, 2023

System.Collections.Immutable.Tests:

Breaking on rolling builds since Apr 17 . The changes since the previous rolling build were - c1b7a9f...63b9a3a .

[22:03:10] fail: [FAIL] System.Collections.Immutable.Tests.ImmutableListTest.BinarySearchPartialSortedList
[22:03:10] info: System.ArgumentOutOfRangeException : Specified argument was out of the range of valid values. (Parameter 'count')
[22:03:10] info:    at System.Reflection.MethodInvoker.Invoke(Object , IntPtr* , BindingFlags )
[22:04:11] fail: [FAIL] System.Collections.Immutable.Tests.ImmutableListBuilderTest.BinarySearchPartialSortedList
[22:04:11] info: System.ArgumentOutOfRangeException : Specified argument was out of the range of valid values. (Parameter 'count')
[22:04:11] info:    at System.Reflection.MethodInvoker.Invoke(Object , IntPtr* , BindingFlags )

cc @radekdoulik (changes include the emsdk bump)

Known Issue Error Message

Fill the error message using known issues guidance.

{
  "ErrorMessage": "",
  "BuildRetry": false
}

Report

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 0 0
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Apr 18, 2023
@ghost
Copy link

ghost commented Apr 18, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

System.Collections.Immutable.Tests:

Breaking on rolling builds since Apr 17 . The changes since the previous rolling build were - c1b7a9f...63b9a3a .

[22:03:10] fail: [FAIL] System.Collections.Immutable.Tests.ImmutableListTest.BinarySearchPartialSortedList
[22:03:10] info: System.ArgumentOutOfRangeException : Specified argument was out of the range of valid values. (Parameter 'count')
[22:03:10] info:    at System.Reflection.MethodInvoker.Invoke(Object , IntPtr* , BindingFlags )
[22:04:11] fail: [FAIL] System.Collections.Immutable.Tests.ImmutableListBuilderTest.BinarySearchPartialSortedList
[22:04:11] info: System.ArgumentOutOfRangeException : Specified argument was out of the range of valid values. (Parameter 'count')
[22:04:11] info:    at System.Reflection.MethodInvoker.Invoke(Object , IntPtr* , BindingFlags )

cc @radekdoulik (changes include the emsdk bump)

Author: radical
Assignees: -
Labels:

arch-wasm, area-Codegen-AOT-mono, test-failure

Milestone: -

@radical radical added this to the 8.0.0 milestone Apr 18, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Apr 18, 2023
@radical radical added the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Apr 18, 2023
radical added a commit to radical/runtime that referenced this issue Apr 20, 2023
radical added a commit that referenced this issue Apr 20, 2023
* [wasm] Disable failing AOT test - System.Collections.Immutable

Issue: #85012

* [wasm] Disable failing AOT tests - System.Runtime.Serialization.Xml*

- System.Runtime.Serialization.Xml.Tests
- System.Runtime.Serialization.Xml.ReflectionOnly.Tests

Issue: #85013
@vargaz vargaz self-assigned this Apr 20, 2023
@vargaz
Copy link
Contributor

vargaz commented Apr 21, 2023

Seems to be caused by #83998, i.e. the emsdk bump. Not sure why CI didn't fail on the PR.

@vargaz
Copy link
Contributor

vargaz commented Apr 21, 2023

Testcase:

using System;
using System.Runtime.InteropServices;
using System.Reflection;
using System.Numerics;
using System.Collections.Generic;
using System.Collections.Immutable;
using System.Linq;
using System.Runtime.CompilerServices;

public class Tests
{
    public static void Main () {
        try {
            Main2 ();
        } catch (Exception ex) {
            Console.WriteLine (ex);
        }
    }

    static void Main2 () {
        ImmutableArray<int> reverseSorted = ImmutableArray.CreateRange(Enumerable.Range(1, 150).Select(n => n * 2).Reverse());
        for (int i = 0; i < 100; ++i)
            foo (reverseSorted);
    }

    static void foo (ImmutableArray<int> inputData)
    {
        Console.WriteLine ("1");
        inputData = inputData.Sort(0, 50, Comparer<int>.Default);
        Console.WriteLine ("2");

        var basis = new List<int>(inputData);
        for (int value = 0; value <= 100000; value++)
                    basis.BinarySearch(0, 50, value, null);
    }
}

Fails in src/mono/samples/wasm/console-v8 when compiled make AOT=1.

vargaz added a commit to vargaz/runtime that referenced this issue Apr 21, 2023
…aluetypes containing object references when they are returned from a method as a scalar.

Fixes dotnet#85012.
@vargaz vargaz closed this as completed in c7aadc0 Apr 22, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Codegen-AOT-mono blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' test-failure
Projects
None yet
Development

No branches or pull requests

2 participants