Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jitstress] JIT/Regression/JitBlue/GitHub_10780 fails #85449

Closed
jakobbotsch opened this issue Apr 27, 2023 · 1 comment · Fixed by #85453
Closed

[jitstress] JIT/Regression/JitBlue/GitHub_10780 fails #85449

jakobbotsch opened this issue Apr 27, 2023 · 1 comment · Fixed by #85453
Assignees
@jakobbotsch
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs JitStress CLR JIT issues involving JIT internal stress modes
Milestone
8.0.0

Comments

@jakobbotsch
Copy link
Member

jakobbotsch commented Apr 27, 2023 •
edited
Loading

#85396 fixed the underlying problem, but physical promotion needs to propagate that flag to indirections it creates. I forgot to port that fix from #85323 in #85343.

Example: https://dev.azure.com/dnceng-public/public/_build/results?buildId=253968&view=ms.vss-test-web.build-test-results-tab&runId=4938610&resultId=106237&paneView=dotnet-dnceng.dnceng-anon-build-release-tasks.helix-anon-test-information-tab
Console log: https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-85349-merge-c2e104fde4d942eca5/Regression_3/1/console.935b901c.log?helixlogtype=result
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 27, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Apr 27, 2023
@ghost
Copy link

ghost commented Apr 27, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

#85396 fixed the underlying problem, but physical promotion needs to propagate that flag to indirections it creates. I forgot to port that fix from #85323 in #85343.

Author: jakobbotsch
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@jakobbotsch jakobbotsch self-assigned this Apr 27, 2023
@jakobbotsch jakobbotsch added blocking-clean-ci-optional Blocking optional rolling runs JitStress CLR JIT issues involving JIT internal stress modes and removed untriaged New issue has not been triaged by the area owner labels Apr 27, 2023
@jakobbotsch jakobbotsch added this to the 8.0.0 milestone Apr 27, 2023
jakobbotsch added a commit to jakobbotsch/runtime that referenced this issue Apr 27, 2023
@jakobbotsch
JIT: Propagate some more indir flags in physical promotion
b782fb7 
When physical promotion creates multiple indirections for arbitrary
BLK/FIELD sources, make sure we propagate all relevant flags.

Fix dotnet#85449
@jakobbotsch jakobbotsch mentioned this issue Apr 27, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Apr 27, 2023
@jakobbotsch jakobbotsch mentioned this issue Apr 27, 2023
Merged
jakobbotsch added a commit that referenced this issue Apr 27, 2023
@jakobbotsch
JIT: Propagate some more indir flags in physical promotion (#85453)
64bd3b1 
When physical promotion creates multiple indirections for arbitrary
BLK/FIELD sources, make sure we propagate all relevant flags.

Fix #85449
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Apr 27, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jakobbotsch jakobbotsch

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs JitStress CLR JIT issues involving JIT internal stress modes
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

JIT: Propagate some more indir flags in physical promotion jakobbotsch/runtime
1 participant
@jakobbotsch