Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Failure - jit64_do.0.1 #85590

Closed
TIHan opened this issue May 1, 2023 · 3 comments · Fixed by #85040
Closed

Test Failure - jit64_do.0.1 #85590

TIHan opened this issue May 1, 2023 · 3 comments · Fixed by #85040
Assignees
@markples
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI GCStress test-failure
Milestone
8.0.0

Comments

@TIHan
Copy link
Contributor

TIHan commented May 1, 2023 •
edited
Loading

Link

runtime-coreclr gcstress0x3-gcstress0xc

18:35:36.365 Running test: JIT/jit64/regress/ddb/87766/ddb87766/ddb87766.cmd
App Exit Code: 259
Expected: 100
Actual: 259
END EXECUTION - FAILED
FAILED
@TIHan TIHan added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI test-failure labels May 1, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label May 1, 2023
@ghost
Copy link

ghost commented May 1, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

runtime-coreclr gcstress0x3-gcstress0xc

18:35:36.365 Running test: JIT/jit64/regress/ddb/87766/ddb87766/ddb87766.cmd
App Exit Code: 259
Expected: 100
Actual: 259
END EXECUTION - FAILED
FAILED
Author: TIHan
Assignees: -
Labels:

area-CodeGen-coreclr, test-failure
Milestone: -

@TIHan TIHan removed the untriaged New issue has not been triaged by the area owner label May 1, 2023
@BruceForstall
Copy link
Member

@TIHan Please include a link to the failure pipeline and indication of which configuration failed.

In this run:

https://dev.azure.com/dnceng-public/public/_build/results?buildId=257442&view=ms.vss-test-web.build-test-results-tab

I see all the failures are in jit64 tests with GCStress=3.

Most are timeouts (@markples -- more GCStress timeouts in merged groups)

win-x64 failure is:

18:46:40.734 Running test: JIT/jit64/regress/vsw/610378/vsw610378/vsw610378.dll
SMALL FRAME SIZE - STATIC
   farg1=1.1 farg2=2.2 expecting 1.1 and 2.2
   bs.f1=1.1 bs.fx=2.2 expecting 1.1 and 2.2
LARGE FRAME SIZE - STATIC
   farg1=1.1 farg2=2.2 expecting 1.1 and 2.2
App Exit Code: 259
Expected: 100
Actual: 259
END EXECUTION - FAILED
FAILED

perhaps that's also a symptom of timeout, since it's the last test run?

@TIHan
Copy link
Contributor Author

TIHan commented May 2, 2023

Sure, will do.

@TIHan TIHan added the GCStress label May 2, 2023
@markples markples mentioned this issue May 5, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label May 5, 2023
@JulieLeeMSFT JulieLeeMSFT added this to the 8.0.0 milestone May 8, 2023
@kunalspathak kunalspathak mentioned this issue May 11, 2023
Merged
markples added a commit that referenced this issue May 18, 2023
@markples
Fix GCStress timeouts in JIT/jit64 (#85040)
fb0b206 
This includes several changes that seem to help with the timeouts. It might be overkill but seems like a good direction as this has been broken for a while.
- Change the test wrapper logic to only put one test in a TestExecutor so that the callstacks are much simpler.
- Factor the test wrapper logic into some helpers to simplify the main method. I also tried to make the "Full" and "XHarness" code generation very similar but didn't try to factor/unify them.
- Mark several tests as RequiresProcessIsolation so that their gcstress is kept separate from the rest of the tests.  Disables a large test under gcstress.
- Add gcstress striping to some merged groups.

Should fix #85590
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label May 18, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@markples markples

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI GCStress test-failure
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Fix GCStress timeouts in JIT/jit64 markples/runtime
4 participants
@TIHan @BruceForstall @markples @JulieLeeMSFT