Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hot reload] Support the GenericAddFieldToExistingType capability in Mono #86111

Closed
Tracked by #57365
lambdageek opened this issue May 11, 2023 · 1 comment · Fixed by #87285
Closed
Tracked by #57365

[hot reload] Support the GenericAddFieldToExistingType capability in Mono #86111

lambdageek opened this issue May 11, 2023 · 1 comment · Fixed by #87285
Assignees
@lambdageek @fanyang-mono
Labels
area-EnC-mono Hot Reload for WebAssembly, iOS/Android, etc

Comments

@lambdageek
Copy link
Member

No description provided.

@lambdageek lambdageek mentioned this issue May 11, 2023
Closed
27 tasks
@ghost ghost added the untriaged New issue has not been triaged by the area owner label May 11, 2023
@lambdageek lambdageek added the area-EnC-mono Hot Reload for WebAssembly, iOS/Android, etc label May 11, 2023
@lambdageek lambdageek self-assigned this May 11, 2023
@lambdageek lambdageek changed the title Support the GenericAddFieldToExistingType capability in Mono [hot reload] Support the GenericAddFieldToExistingType capability in Mono May 11, 2023
@lambdageek
Copy link
Member Author

This will need a little bit of research to understand the scope of the work. But now that we have delta info on generic instances (that we added for props and events) we can hang MonoClassField elements on instances, too.

The runtime storage for fields will probably just work transparently.

@lambdageek lambdageek removed untriaged New issue has not been triaged by the area owner area-VM-meta-mono labels May 11, 2023
@lambdageek lambdageek mentioned this issue Jun 8, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jun 8, 2023
lambdageek added a commit that referenced this issue Jun 16, 2023
@lambdageek
[hot reload][mono] Implement support for adding static and instance f…
71ee9ea 
…ields to generic classes (#87285)

Fixes #86111

* new test adding a generic field

* workaround roslyn issue to generate generic static field test

   dotnet/roslyn#68293 we get an error if we add a generic field and try to use it during the same edit. workaround is to do two separate edits

* implement hot reload for static fields in generics

   ldsflda seems to be working

* Add a generic instance add instance field test

* add reflection testing to the generic instance added field test

* fixup valuetype loads

* add non-generic valuetype ldflda test

* Mark failing tests for CoreCLR

* light up GenericAddFieldToExistingType capability

* use interp_emit_ldobj for metadata-update; add barrier if volatile
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jun 16, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lambdageek lambdageek

@fanyang-mono fanyang-mono

Labels
area-EnC-mono Hot Reload for WebAssembly, iOS/Android, etc
Projects
None yet
Milestone
No milestone
2 participants
@lambdageek @fanyang-mono