Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono][ios] System.Formats.Tar.Tests are failing with System.ArgumentException #88049

Closed
kotlarmilos opened this issue Jun 26, 2023 · 8 comments · Fixed by #95861
Closed

[mono][ios] System.Formats.Tar.Tests are failing with System.ArgumentException #88049

kotlarmilos opened this issue Jun 26, 2023 · 8 comments · Fixed by #95861
Assignees
Labels
area-System.Formats.Tar blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' os-tvos Apple tvOS
Milestone

Comments

@kotlarmilos
Copy link
Member

kotlarmilos commented Jun 26, 2023

Build Information

Build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=320749&view=results
Build error leg or test failing: iossimulator-x64 Release AllSubsets_Mono
Pull request: #88042

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": "System.ArgumentException : The field 'Name' exceeds the maximum allowed length for this format",
  "ErrorPattern": "",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=320749
Result validation: ✅ Known issue matched with the provided build.

Report

Build Definition Test Pull Request
495924 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
492182 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution #95757
491743 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution #95733
489669 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
484466 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
478851 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
478790 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
478779 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
477633 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
477305 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
476004 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
473580 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
473434 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
473400 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
472901 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
472857 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
471800 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
471653 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
471584 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
471393 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
470325 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
468967 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
468844 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
468590 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
468095 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 3 25
@kotlarmilos kotlarmilos added blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' area-Codegen-AOT-mono os-tvos Apple tvOS Known Build Error Use this to report build issues in the .NET Helix tab labels Jun 26, 2023
@kotlarmilos kotlarmilos added this to the 8.0.0 milestone Jun 26, 2023
@ghost
Copy link

ghost commented Jun 26, 2023

Tagging subscribers to 'os-tvos': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

Build Information

Build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=320749&view=results
Build error leg or test failing: iossimulator-x64 Release AllSubsets_Mono
Pull request: #88042

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": "System.ArgumentException : The field 'Name' exceeds the maximum allowed length for this format",
  "ErrorPattern": "",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}
Author: kotlarmilos
Assignees: -
Labels:

blocking-clean-ci, area-Codegen-AOT-mono, os-tvos, Known Build Error

Milestone: 8.0.0

@kotlarmilos
Copy link
Member Author

@carlossanlop It seems that the regression was introduced in #87534. The issue appears to be specific to the ios and tvos simulators.

@ghost
Copy link

ghost commented Jul 11, 2023

Tagging subscribers to this area: @dotnet/area-system-formats-tar
See info in area-owners.md if you want to be subscribed.

Issue Details

Build Information

Build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=320749&view=results
Build error leg or test failing: iossimulator-x64 Release AllSubsets_Mono
Pull request: #88042

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": "System.ArgumentException : The field 'Name' exceeds the maximum allowed length for this format",
  "ErrorPattern": "",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=320749
Result validation: ✅ Known issue matched with the provided build.

Report

Build Definition Test Pull Request
335161 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution #88167
335062 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution #88655
334957 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
334907 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
334799 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution #88611
334721 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
334375 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
334256 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
334160 dotnet/runtime System.Formats.Tar.Tests.TarFile_ExtractToDirectoryAsync_Stream_Tests.ExtractToDirectory_ExactRootDirMatch_RegularFile_And_Directory_Throws_Async #79856
334061 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
333900 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution #88539
333413 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
333175 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
333001 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
332951 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution #88548
332861 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
332635 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
332434 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
332206 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution #88529
331700 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
331369 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
331212 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
331172 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
330937 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
330588 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
330527 dotnet/runtime System.Formats.Tar.Tests.TarFile_ExtractToDirectory_Stream_Tests.ExtractToDirectory_ExactRootDirMatch_RegularFile_And_Directory_Throws
330387 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
329962 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
329893 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution #88436
329717 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution #88345
329472 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
329361 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution #88345
329210 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
328828 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution #88322
328822 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
328678 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution #88345
328688 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution #88360
328529 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
328443 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution #88322
328406 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution #88345
328385 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution #88342
328094 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution #88322
327993 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution #88184
327970 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
327756 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
327594 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
327515 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
327457 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution #88025
327273 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
327078 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution #88163
326915 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
326636 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution #88261
326417 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
326087 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
326071 dotnet/runtime System.Formats.Tar.Tests.TarFile_ExtractToDirectory_Stream_Tests.ExtractToDirectory_ExactRootDirMatch_RegularFile_And_Directory_Throws #88025
325633 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution #88163
325552 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
325432 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
325382 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution #88163
325122 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution #87175
324891 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
324452 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution #88167
324371 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
323893 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution #88113
323521 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
322934 dotnet/runtime System.Formats.Tar.Tests.TarFile_ExtractToDirectory_Stream_Tests.ExtractToDirectory_ExactRootDirMatch_RegularFile_And_Directory_Throws
322681 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution #87260
322518 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution #88094
322048 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
321994 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
321687 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
321510 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
321501 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
321392 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
320749 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution #88042
320642 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution #88036
320422 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution
320144 dotnet/runtime System.Formats.Tar.Tests.WorkItemExecution

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
11 33 78
Author: kotlarmilos
Assignees: -
Labels:

blocking-clean-ci, area-Codegen-AOT-mono, os-tvos, Known Build Error, area-System.Formats.Tar

Milestone: 8.0.0

@kotlarmilos
Copy link
Member Author

kotlarmilos commented Jul 24, 2023

This fails only on apple mobile simulators that run Mono Interpreter. My assumption is that the GetUtf8TextLength doesn't return the same value with Interpreter and AOT, but still have to confirm that locally.

/cc: @BrzVlad

const ushort limit = 100;
ReadOnlySpan<char> name = _name;
int encodedLength = GetUtf8TextLength(name);

if (encodedLength > FieldLengths.Name)
{
    if (_format is TarEntryFormat.V7)
    {
        throw new ArgumentException(SR.Format(SR.TarEntryFieldExceedsMaxLength, nameof(TarEntry.Name)), ArgNameEntry);
    }

    int utf16NameTruncatedLength = GetUtf16TruncatedTextLength(name, FieldLengths.Name);
    name = name.Slice(0, utf16NameTruncatedLength);
}

@kotlarmilos
Copy link
Member Author

This issue is also occurring on iOS/tvOS devices. For instance in: https://dev.azure.com/dnceng-public/public/_build/results?buildId=357141&view=results. The length of fields exceeds the values set in:

@carlossanlop Should we update the fields length to match the following examples?

public static IEnumerable<object[]> GetExactRootDirMatchCases()

@carlossanlop
Copy link
Member

Hi - The Path length used for V7 should stay as is, it's what the spec indicates and it should be respected.

The test could be modified so that the temporary path directory is created with a much shorter path. Would that work?

@steveisok
Copy link
Member

Hi - The Path length used for V7 should stay as is, it's what the spec indicates and it should be respected.

The test could be modified so that the temporary path directory is created with a much shorter path. Would that work?

Yes, definitely.

@kotlarmilos kotlarmilos removed the Known Build Error Use this to report build issues in the .NET Helix tab label Aug 10, 2023
@kotlarmilos kotlarmilos modified the milestones: 8.0.0, 9.0.0 Aug 10, 2023
@build-analysis build-analysis bot removed this from the 9.0.0 milestone Nov 15, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Nov 15, 2023
@carlossanlop carlossanlop added this to the 9.0.0 milestone Dec 6, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Dec 6, 2023
@carlossanlop
Copy link
Member

@kotlarmilos @steveisok the folder used to store files needs to have a shorter path for the test to work (the failure is expected for this tar format). Can you please change it to a shorter directory for this platform?

@kotlarmilos kotlarmilos self-assigned this Dec 6, 2023
@ghost ghost added in-pr There is an active PR which will close this issue when it is merged and removed in-pr There is an active PR which will close this issue when it is merged labels Dec 7, 2023
@ghost ghost added in-pr There is an active PR which will close this issue when it is merged and removed in-pr There is an active PR which will close this issue when it is merged labels Dec 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Formats.Tar blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' os-tvos Apple tvOS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants