-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0-staging] #76881 internal properties in GetRuntimeProperties are not shown #87175
[release/7.0-staging] #76881 internal properties in GetRuntimeProperties are not shown #87175
Conversation
Tagging subscribers to this area: @dotnet/area-system-reflection Issue DetailsBackport of #77169 to release/7.0-staging /cc @mkhamoyan Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
/azp run runtime-android |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
@mkhamoyan @lambdageek Today is code complete for the July servicing release. Pleaseget a Tactics approval and merge before EOD if you'd like this to be included in the release. |
/azp run runtime-ioslike |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
@carlossanlop thank you very much for the information. However, merging this PR is not urgent and we want to make sure that |
Failures are related to some infrastructure issues
|
Shall we try to rerun |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
Failing tests are not related to this PR changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Backport of #77169 to release/7.0-staging
/cc @mkhamoyan
Customer Impact
Customers who upgraded from Xamarin to MAUI experienced a difference in reflection behavior when getting all properties from a type. In MAUI, protected properties from a parent class were not returned reported here: #86149
Testing
Added a test that covers this scenario and it passes.
Risk
Low as by this change while getting all properties for a type, the protected properties declared in inherited type will be returned as well.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging
, notrelease/X.0
.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.