-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider matching ETW to fire the new events added to EventPipe #88162
Comments
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsFor new events added to
|
Another aspect of this is that the GC events already emitted via ETW in .NET 7 are emitted regardless of whether or not EventSource support is enabled. Would we want the same behaviour for these other events? That seems to go against the desire to strip out anything unnecessary in NativeAOT / make things opt-in, but it would also be weird to always have only (a subset of) GC events and require enabling EventSource support for the other runtime events. Or they could all be switched to opt-in - but I'm not sure what existing scenarios may rely on the existing ETW events being non-opt-in. Keeping the ETW events as always on makes for a lack of consistency/parity cross-plat (in addition to going against our desire for minimalism in NativeAOT). I'd think that ETW event support belongs in the same category as EventPipe support - in which case it would be opt-in. |
We have done work to make this easier (see above merged PRs) but doing this in .NET9 seems ok given our aim for .NET8 is for basic functionality. |
We now use gen-eventing-event-inc.lst as the allowed events for both |
For new events added to
NativeAOT
, we are prioritizing enabling these viaEventPipe
given that its cross-platform (see PR #87785 for an example). Getting events viaEventPipe
is our primary focus, and tools likePerfView
can see these events with enabling the relevant providers (for example,Microsoft-DotNet-Runtime
provider). But given thatETWProvider
has been supported in .NET7, we should strive to add the new events to be enabled via ETW as well.The text was updated successfully, but these errors were encountered: