Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Webassembly] dotnet/runtime update broke the aspnetcore build #88250

Closed
javiercn opened this issue Jun 30, 2023 · 2 comments · Fixed by #88264
Closed

[Webassembly] dotnet/runtime update broke the aspnetcore build #88250

javiercn opened this issue Jun 30, 2023 · 2 comments · Fixed by #88264
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm

Comments

@javiercn
Copy link
Member

There was a dotnet/runtime dependency update that broke the aspnetcore build (apparently, someone on our team merged on red) https://github.com/dotnet/aspnetcore/pull/49075/checks?check_run_id=14669346751

The issue seems to be related to localization/globalization with some languages.

Could you folks take a look asap?

/cc: @lewing @maraf @ilonatommy

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 30, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jun 30, 2023
@ilonatommy
Copy link
Member

It might be this line:

- const applicationCulture = resourceLoader.startOptions.applicationCulture || (navigator.languages && navigator.languages[0]);
+ const applicationCulture = resourceLoader.startOptions.applicationCulture || ENVIRONMENT_IS_WEB ? (navigator.languages && navigator.languages[0]) : Intl.DateTimeFormat().resolvedOptions().locale;

because we apparently load en-US instead of cultures we would like to test. It means the applicationCulture is recognized incorrectly. The change to that line was done between the last successful update and the one that is failing, in #86255. I will try to test if this theory is correct.

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jun 30, 2023
@maraf maraf added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm and removed untriaged New issue has not been triaged by the area owner labels Jun 30, 2023
@ghost
Copy link

ghost commented Jun 30, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

There was a dotnet/runtime dependency update that broke the aspnetcore build (apparently, someone on our team merged on red) https://github.com/dotnet/aspnetcore/pull/49075/checks?check_run_id=14669346751

The issue seems to be related to localization/globalization with some languages.

Could you folks take a look asap?

/cc: @lewing @maraf @ilonatommy

Author: javiercn
Assignees: -
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, in-pr, needs-area-label, os-browser

Milestone: -

@maraf maraf removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 30, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jun 30, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants