[browser] Unify boot config schema and output layout

[maraf]

• Update WasmAppBuilder to produce the same boot config schema as GenerateWasmBootJson
• Update AppBundle layout to match blazor layout.
  • All the runtime files (js, wasm, icu) are deployed to _framework folder.
  • This behavior can be overriden by setting <WasmRuntimeAssetsLocation> property. The empty value is overriden to default _framework, but ./ can be used to flatten the output structure.
  • WBT test with flat output
  • The only remaining difference is AppBundle vs wwwrooot folder name.
• JSHost.ImportAsync now requires the same relative paths as in blazor (./module.js => ../module.js)

Contributes to #70762

[ghost]

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Unify scheme between GenerateWasmBootJson and WasmAppBuilder

Author:	maraf
Assignees:	maraf
Labels:	arch-wasm, area-Build-mono
Milestone:	8.0.0

[radical]

@ilonatommy can you please check the icu bits in WasmAppBuilder?

[maraf]

/azp run runtime-wasm

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[radical]

I tried to verify this with a dotnet-runtime-perf run, but that timed out because of resource issues. Try running some benchmarks (even one will do) using instructions from https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md#dotnet-runtime-testing-for-wasm .

[ilonatommy]

ICU related part looks good

[maraf]

@radical dotnet/performance is missing --module when running V8. If I hacked around with --wasmArgs I was able to convince it to run with test-main.js from this PR.

Do you have more feedback?

[radical]

@radical dotnet/performance is missing --module when running V8. If I hacked around with --wasmArgs I was able to convince it to run with test-main.js from this PR.

Do you have more feedback?

This is handled for CI, and the docs for manual running need to be updated.
But I just realized that it will be problematic with the file (test-main.mjs) being renamed only in the scripts. I will try a simple fix in perf repo, and open a PR for it, and then you can update this PR.

[maraf]

/azp run runtime-wasm

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[radical]

@radical dotnet/performance is missing --module when running V8. If I hacked around with --wasmArgs I was able to convince it to run with test-main.js from this PR.
Do you have more feedback?

This is handled for CI, and the docs for manual running need to be updated. But I just realized that it will be problematic with the file (test-main.mjs) being renamed only in the scripts. I will try a simple fix in perf repo, and open a PR for it, and then you can update this PR.

The fixes will take a little longer. They are blocked by other things, for example dotnet/BenchmarkDotNet#2346 .

[radical]

@maraf I've pushed a commit to add --module for v8.

The reason the break shows up in this PR, and not on main is:

-                File.Copy(Path.Combine(AppContext.BaseDirectory,
-                                        options.TargetFramework == "net8.0" ? "test-main.js" : "data/test-main-7.0.js"),
-                            Path.Combine(_projectDir, "test-main.js"));
+                File.Copy(
+                    Path.Combine(
+                        AppContext.BaseDirectory,
+                        string.IsNullOrEmpty(options.TargetFramework) || options.TargetFramework == "net8.0"
+                            ? "test-main.js"
+                            : "data/test-main-7.0.js"
+                    ),
+                    Path.Combine(_projectDir, "test-main.js")
+                );

In the options.TargetFramework case it was using the older test-main-7.0.js. Testing wise it is not a big issue since this is essentially testing for library tests, but your changes fixes it to use the current file.

In my upcoming PRs I will be moving most of the WBT tests away from test-main*, to use templates instead.

[radical]

LGTM! Great job 👍

[maraf]

@maraf I've pushed a commit to add --module for v8.

The reason the break shows up in this PR, and not on main is:

-                File.Copy(Path.Combine(AppContext.BaseDirectory,
-                                        options.TargetFramework == "net8.0" ? "test-main.js" : "data/test-main-7.0.js"),
-                            Path.Combine(_projectDir, "test-main.js"));
+                File.Copy(
+                    Path.Combine(
+                        AppContext.BaseDirectory,
+                        string.IsNullOrEmpty(options.TargetFramework) || options.TargetFramework == "net8.0"
+                            ? "test-main.js"
+                            : "data/test-main-7.0.js"
+                    ),
+                    Path.Combine(_projectDir, "test-main.js")
+                );

In the options.TargetFramework case it was using the older test-main-7.0.js. Testing wise it is not a big issue since this is essentially testing for library tests, but your changes fixes it to use the current file.

In my upcoming PRs I will be moving most of the WBT tests away from test-main*, to use templates instead.

Thank you for tracking it down!