-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser] Unify boot config schema and output layout #86255
Merged
Merged
Changes from 85 commits
Commits
Show all changes
89 commits
Select commit
Hold shift + click to select a range
3ab43ea
WIP
maraf 9d4ddc5
Assets hash
maraf 1c44c21
VFS
maraf c74bb29
Drop RemoteSources
maraf c1903bb
Disable nullable in BootJsonData
maraf 0928652
Load VFS in JS
maraf b8fe6e5
Add dotnetwasm to runtimeAssets
maraf eaca5a6
Fix null config.resources.pdb
maraf 784a09a
Fix null config.resources.satelliteResources
maraf 859c46f
Fix dotnetwasm hash
maraf 8ebcce8
Handle symbols in blazor path
maraf c709ba3
Move everything in _framework folder
maraf b32d5a3
Update path to dotnet.js in imports
maraf 1581b76
Fix configSrc path in advanced sample
maraf 105b35c
Merge remote-tracking branch 'upstream/main' into WasmUnifyBootConfig…
maraf d1abc9a
Fix merge
maraf 3e67550
Merge branch 'main' into WasmUnifyBootConfigSchema
maraf dca3ae7
Drop logging
maraf 7c2b383
Console friendly
maraf cfddfd6
TMP TO REVERT
maraf 280fe69
Fix build
maraf bbde368
Console friendly
maraf 9ffdf75
Merge remote-tracking branch 'upstream/main' into WasmUnifyBootConfig…
maraf 3c7d14c
Fix null extensions
maraf dac75e7
A bit more work on WasmExtraConfig
maraf a3a3346
Propagate assetUniqueQuery
maraf 52f796d
Fix pthreadPoolSize
maraf 33843cb
Fix default globalization
maraf 7f2a16e
Fix virtualPath for VFS entries
maraf 4a39857
Share BootJsonData
maraf 293d270
Call setupModuleForBlazor on web. Drop disableDotnet6Compatibility be…
maraf c08752d
WBT fix paths
maraf 464554b
Merge remote-tracking branch 'upstream/main' into WasmUnifyBootConfig…
maraf 724cd78
Globalization
maraf b58f61b
test-main arg --no-exit
maraf c385a62
Fix MonoJsTests
maraf 29c5287
Fix wbt managed
maraf dd40afb
Merge remote-tracking branch 'upstream/main' into WasmUnifyBootConfig…
maraf 29eec40
loadAllSatelliteResources on startup
maraf d005783
Remote sources
maraf 290a78e
Fix environment variables
maraf 8836468
Merge remote-tracking branch 'upstream/main' into WasmUnifyBootConfig…
maraf 61a7ca4
Fix relative path to the imported modules in JS tests
maraf 76864f1
Fix hybrid. These changes will come from a different PR
maraf 8efa39c
Threading
maraf 3e9dd79
Fix imports
maraf 0f45395
Fix culture on v8/node
maraf 6edc837
Merge remote-tracking branch 'upstream/main' into WasmUnifyBootConfig…
maraf a58082b
Merge remote-tracking branch 'upstream/main' into WasmUnifyBootConfig…
maraf b137849
Drop enableDownloadRetry=false and maxParallelDownloads
maraf c4d3fa0
Properly set hybrid globalization
maraf c236198
Fix merging configs
maraf 5ab1b0b
Use latest test-main for .NET 8.0 or empty target framework
maraf 793ce2b
Merge remote-tracking branch 'upstream/main' into WasmUnifyBootConfig…
maraf 01c6104
Feedback
maraf b0f7f4d
Fix WAB
maraf 7c377fb
Fix threads-minimal sample
maraf 91162cb
Fix WBT using GetFilesTable
maraf ca4c6f3
Feedback
maraf 90ccf1f
Syntax
maraf b871e28
WasmRuntimeAssetsLocation
maraf 51d7222
WasmEnableRuntimeAssetsLocation
maraf 5a88c5c
Revert --no-exit
maraf 6fc1f06
WasmEnableRuntimeAssetsLocation default value comment
maraf f832ac0
Flat output structure for advanced sample
maraf f5c07cd
Feedback
maraf 2ff44c8
Fix browser-threads-minimal
maraf b523c63
Merge remote-tracking branch 'upstream/main' into WasmUnifyBootConfig…
maraf 8a5f657
Use flat structure for template wbt
maraf cc0568c
Use flat structure for template wbt (fix)
maraf 8c1f461
Fix WBT hybrid
maraf cb6ffa1
More WBT fixes
maraf b23186e
Update dotnet.js import in templates
maraf 270c00d
Rename test-main.js to test-main.mjs
maraf 16474e9
Rename test-main.js to test-main.mjs (2)
maraf c7c9efa
Merge remote-tracking branch 'upstream/main' into WasmUnifyBootConfig…
maraf f8b415e
WBT icu
maraf aed2640
WBT templates
maraf 0445f7c
WBT with flat output
maraf d4c4db8
Always asume blazor.boot.json is next to the dotnet.js (if not specif…
maraf 71ec250
Feedback
maraf 023387f
Feedback WBT templates
maraf e690d6e
Feedback symbols
maraf 6c7eb28
DebugLevel
maraf ccf8234
Feedback WasmRuntimeAssetsLocation message
maraf 2e119ce
Revert "Rename test-main.js to test-main.mjs"
maraf 9c0ce98
Merge remote-tracking branch 'origin/main' into WasmUnifyBootConfigSc…
radical e027248
[wasm] WBT: Add --module for enabling use of es6 modules
radical d059cec
Add --module only for v8
radical File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...vices.JavaScript.UnitTests/System/Runtime/InteropServices/JavaScript/SecondRuntimeTest.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So anyone consuming the runtime needs to hardcode _framework into their paths now, I guess this is an official part of the ABI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, changing layout is breaking change for non-blazor templates.
I'm OK with it.cc @radical @lewing
Edit: I don't like the "hardcoging" part of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would it take to make the deployment path configurable ? And only make it
_framework
for Blazor ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should be as a close to blazor as possible. Since non-blazor templates are "experimental", I wouldn't about it much, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to get to blazor by setting some properties, but the default should not be blazor. We do have the browser/console templates.