Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NativeAOT EventPipe require multi byte to wide char support #88785

Closed
LakshanF opened this issue Jul 12, 2023 · 3 comments
Closed

NativeAOT EventPipe require multi byte to wide char support #88785

LakshanF opened this issue Jul 12, 2023 · 3 comments
Assignees
@LakshanF
Labels
area-NativeAOT-coreclr
Milestone
8.0.0

Comments

@LakshanF
Copy link
Contributor

EventPipe ep_rt_utf8_to_utf16le_string and ep_rt_utf16_to_utf8_string implementation currently only supports ASCII conversions. These need to support multi-byte conversions.

This recent work looks promising in terms of leveraging common code for this purpose
@LakshanF LakshanF added this to the 8.0.0 milestone Jul 12, 2023
@LakshanF LakshanF self-assigned this Jul 12, 2023
@ghost
Copy link

ghost commented Jul 12, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

EventPipe ep_rt_utf8_to_utf16le_string and ep_rt_utf16_to_utf8_string implementation currently only supports ASCII conversions. These need to support multi-byte conversions.

This recent work looks promising in terms of leveraging common code for this purpose

Author: LakshanF
Assignees: LakshanF
Labels:

area-NativeAOT-coreclr
Milestone: 8.0.0

@am11
Copy link
Member

am11 commented Jul 12, 2023 •
edited
Loading

I think it is possible to make EP directly call minipal_convert_utf8_to_utf16 and minipal_convert_utf16_to_utf8 APIs without duplicating the calling code for each runtime. Currently, EP for both coreclr and mono end up calling exactly the same minipal APIs via different wrappers; PAL or giconv.

@LakshanF
Copy link
Contributor Author

Fixed with #89036

@ghost ghost locked as resolved and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@LakshanF LakshanF

Labels
area-NativeAOT-coreclr
Projects
AppModel
Archived in project
Milestone
8.0.0
Development

No branches or pull requests
2 participants
@am11 @LakshanF