Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] loadBootResource should not ask for dotnetwasm location before cache lookup #89883

Closed
pavelsavara opened this issue Aug 2, 2023 · 1 comment · Fixed by #89857
Closed

[browser] loadBootResource should not ask for dotnetwasm location before cache lookup #89883

pavelsavara opened this issue Aug 2, 2023 · 1 comment · Fixed by #89857
Assignees
@pavelsavara
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Milestone
8.0.0

Comments

@pavelsavara
Copy link
Member

Because

https://github.com/dotnet/aspnetcore/blob/22b8ebb68bf74371b038841ea461d74da03182b9/src/Components/WebAssembly/testassets/HostedInAspNet.Client/wwwroot/index.html#L21

will force real fetch.

That breaks caching tests in BootResourceCachingTest
https://github.com/dotnet/aspnetcore/blob/22b8ebb68bf74371b038841ea461d74da03182b9/src/Components/test/E2ETest/Tests/BootResourceCachingTest.cs#L18
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture os-browser Browser variant of arch-wasm labels Aug 2, 2023
@pavelsavara pavelsavara added this to the 8.0.0 milestone Aug 2, 2023
@pavelsavara pavelsavara self-assigned this Aug 2, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 2, 2023
@ghost
Copy link

ghost commented Aug 2, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Because

https://github.com/dotnet/aspnetcore/blob/22b8ebb68bf74371b038841ea461d74da03182b9/src/Components/WebAssembly/testassets/HostedInAspNet.Client/wwwroot/index.html#L21

will force real fetch.

That breaks caching tests in BootResourceCachingTest
https://github.com/dotnet/aspnetcore/blob/22b8ebb68bf74371b038841ea461d74da03182b9/src/Components/test/E2ETest/Tests/BootResourceCachingTest.cs#L18

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, os-browser
Milestone: 8.0.0

pavelsavara added a commit to dotnet/aspnetcore that referenced this issue Aug 2, 2023
@pavelsavara
active issue dotnet/runtime#89883
edccd73
dotnet-maestro bot added a commit to dotnet/aspnetcore that referenced this issue Aug 2, 2023
@dotnet-maestro
[main] Update dependencies from dotnet/runtime dotnet/efcore (#49704)
dacb224 
[main] Update dependencies from dotnet/runtime dotnet/efcore


 - React to the new NativeAOT annotations in EF

 - Merge remote-tracking branch 'origin/main' into darc-main-42aacfbe-ed21-4d49-84b9-a3a4395f168f

 - cleanup of the wasm runtime dependency

 - active issue dotnet/runtime#89883
@pavelsavara pavelsavara added area-System.Runtime.InteropServices.JavaScript and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Aug 3, 2023
@pavelsavara pavelsavara mentioned this issue Aug 3, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 3, 2023
pavelsavara added a commit to pavelsavara/runtime that referenced this issue Aug 3, 2023
@pavelsavara
fix for dotnet#89883
a8e6e9b
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 8, 2023
@pavelsavara pavelsavara reopened this Aug 8, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

[browser] app start benchmark fix, loadBootResource fix pavelsavara/runtime
1 participant
@pavelsavara