-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete the non portable RID graph in a future release of .NET #90000
Comments
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsFollow-up on dotnet/sdk#34279
|
Fixes #90000 Follow-up on dotnet/sdk#34279
Do we want to delete this entirely? The SDK still consumes and includes the old runtime graph from dotnet/runtime, and projects can opt in to using it by setting |
We don't want anyone to mutate the current runtime.json RID graph anymore. It's de-facto frozen. I was under the impression that the full RID graph already moved to the SDK with your recent change. I think we should do that. |
No, so far only the trimmed-down, portable graph has been moved to the SDK. The full RID graph still comes from runtime. |
I see, thanks for the clarification. Any objection to moving it over? We don't want to ship new versions of Microsoft.NetCore.Platforms anymore, nor do we want to have a transport package, only to carry over a checked-in, frozen asset to the sdk repository. |
gentle ping @dsplaisted. Whatever we do, we should do it asap as the cut-off for RC1 is approaching. Would you mind adding the full RID graph into the sdk repository and removing the dependency on Microsoft.NETCore.Platforms? |
I would prefer to wait until .NET 9 to make the changes to runtime if that's OK. The RID changes are coming in kind of late for .NET 8, and I'd prefer to avoid extra churn. This shouldn't affect any runtime or SDK behavior, right, it's just about simplifying the runtime build? |
We want to stop shipping the Microsoft.NETCore.Platforms package to make it clear that the graph is frozen. The package today appears on nuget.org. While we could just make it a transport package for the current release, I wonder if it wouldn't be easier to just move the graph into the sdk repo. I'm fine with either option for .NET 8. |
I would prefer for .NET 8 to just mark it as a transport package, and then remove it for .NET 9. |
The full RID graph is frozen and won't change anymore. Mark the Microsoft.NETCore.Platforms nuget package as non-shipping as only the sdk repository still requires it. Contributes to #90000
The full RID graph is frozen and won't change anymore. Mark the Microsoft.NETCore.Platforms nuget package as non-shipping as only the sdk repository still requires it. Contributes to #90000
Follow-up on dotnet/sdk#34279, see discussion in #92211
The text was updated successfully, but these errors were encountered: