Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono][docs] Change build/run individual runtime test example #90254

Closed
2 tasks done
matouskozak opened this issue Aug 9, 2023 · 4 comments
Closed
2 tasks done

[mono][docs] Change build/run individual runtime test example #90254

matouskozak opened this issue Aug 9, 2023 · 4 comments
Assignees
Labels
area-Infrastructure-mono documentation Documentation bug or enhancement, does not impact product or test code
Milestone

Comments

@matouskozak
Copy link
Member

matouskozak commented Aug 9, 2023

Description

Provide a different example for building, running, and debugging of individual runtime tests for Mono Testing documentation https://github.com/dotnet/runtime/blob/main/docs/workflow/testing/mono/testing.md. The current example (JIT/opt/InstructionCombining/DivToMul.csproj) doesn't generate .sh file which could be later used to run or debug the test #84284.

This can by "hacked" locally by adding <RequiresProcessIsolation>True</RequiresProcessIsolation> to the DivToMul.csproj file.

Tasks

@matouskozak matouskozak added the documentation Documentation bug or enhancement, does not impact product or test code label Aug 9, 2023
@matouskozak matouskozak added this to the Future milestone Aug 9, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 9, 2023
@matouskozak matouskozak self-assigned this Aug 9, 2023
@SingleAccretion
Copy link
Contributor

Is the documentation missing /p:BuildAsStandalone=true?

@matouskozak
Copy link
Member Author

Is the documentation missing /p:BuildAsStandalone=true?

Thanks, I wasn't aware of this variable. When I set the variable as export BuildAsStandalone=true it indeed generates the .sh script. However, when I pass it to the ./src/tests/build.sh as /p:BuildAsStandalone=true it doesn't work. Do you know what am I missing?

@SingleAccretion
Copy link
Contributor

Do you know what am I missing?

I don't know if it is supposed to work when passed to the top-level build script (could be a bug). I do know it is supposed to work when dotnet building individual tests.

@ghost
Copy link

ghost commented Aug 10, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Provide a different example for building, running, and debugging of individual runtime tests for Mono Testing documentation https://github.com/dotnet/runtime/blob/main/docs/workflow/testing/mono/testing.md. The current example (JIT/opt/InstructionCombining/DivToMul.csproj) doesn't generate .sh file which could be later used to run or debug the test #84284.

This can by "hacked" locally by adding <RequiresProcessIsolation>True</RequiresProcessIsolation> to the DivToMul.csproj file.

Author: matouskozak
Assignees: matouskozak
Labels:

documentation, area-Infrastructure-mono, needs-area-label

Milestone: Future

@vcsjones vcsjones removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 10, 2023
matouskozak added a commit that referenced this issue Dec 15, 2023
…tests

Due to optimizing effort of building and running runtime tests #54512, some tests don't generate `*.sh` files by default after build. It is necessary to `export BuildAsStandalone=true` or modify the test's `.csproj` file.

---

Contributes to: #90254
matouskozak added a commit that referenced this issue Dec 15, 2023
…tests

Due to optimizing effort of building and running runtime tests #54512, some tests don't generate `*.sh` files by default after build. It is necessary to `export BuildAsStandalone=true` or modify the test's `.csproj` file.

---

Contributes to: #90254
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-mono documentation Documentation bug or enhancement, does not impact product or test code
Projects
None yet
Development

No branches or pull requests

4 participants