Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mono] Investigate the issue with trimming Mono.Android.dll #90403

Closed
Tracked by #80953
fanyang-mono opened this issue Aug 11, 2023 · 2 comments
Closed
Tracked by #80953

[Mono] Investigate the issue with trimming Mono.Android.dll #90403

fanyang-mono opened this issue Aug 11, 2023 · 2 comments
Assignees
@fanyang-mono
Labels
area-VM-meta-mono
Milestone
9.0.0

Comments

@fanyang-mono
Copy link
Member

When enabling trimming for Mono.Android.dll, android app crashed on startup. Investigate and fix the issue behind this.

Then remove the workaround added in #90106
@fanyang-mono fanyang-mono added this to the 9.0.0 milestone Aug 11, 2023
@fanyang-mono fanyang-mono self-assigned this Aug 11, 2023
This was referenced Aug 11, 2023
Open
Closed
@lambdageek
Copy link
Member

I think we should disable the hack from #90106 regardless of the outcome of this investigation before the .NET 8 RTM. If we don't have a real fix, we shouldn't ship the ILStrip feature

@fanyang-mono
Copy link
Member Author

This is not needed any more. I've found the root cause of this. See comments at #88538 (comment)

@ghost ghost locked as resolved and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fanyang-mono fanyang-mono

Labels
area-VM-meta-mono
Projects
None yet
Milestone
9.0.0
Development

No branches or pull requests
2 participants
@lambdageek @fanyang-mono