Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mono] Add a workaround for android apps, in order to leverage the feature of trimming compiled methods #90106

Closed
wants to merge 3 commits into from

Conversation

fanyang-mono
Copy link
Member

@fanyang-mono fanyang-mono commented Aug 7, 2023

Fixes #88538

When enabling IL trim for Android apps, the size of the app got smaller

  • The size of dotnet Android template app apk file: 7.7M -> 7.6M (1.3% smaller)
  • The size of assemblies/assemblies.blob from maui template app built for android: 254,396 bytes -> 253,952 bytes (1.21% smaller)

@vargaz
Copy link
Contributor

vargaz commented Aug 7, 2023

Some other assembly might cause the same problem.

@fanyang-mono
Copy link
Member Author

Some other assembly might cause the same problem.

This is a temporary workaround to enable the customers to try out this new feature. I've create an issue to track the task of fixing the real problem behind it. (#90403)

Copy link
Member

@lambdageek lambdageek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't like this. What is the plan for backing this out before RTM?

@fanyang-mono
Copy link
Member Author

This is not needed any more. I've found the root cause of this. See comments at #88538 (comment)

@ghost ghost locked as resolved and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android: new cil-strip feature causes app crashes
3 participants