Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NativeAOT Checked smoke tests are taking a long time #91296

Closed
agocke opened this issue Aug 29, 2023 · 2 comments · Fixed by #92825
Closed

NativeAOT Checked smoke tests are taking a long time #91296

agocke opened this issue Aug 29, 2023 · 2 comments · Fixed by #92825

Comments

@agocke
Copy link
Member

agocke commented Aug 29, 2023

Debug takes about 40 minutes, but Checked takes > 120 minutes. We should figure out what check is taking such a long time. If it's important, we might want to move the test suite to runtime-extra-platforms.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Aug 29, 2023
@ghost
Copy link

ghost commented Aug 29, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Debug takes about 40 minutes, but Checked takes > 120 minutes. We should figure out what check is taking such a long time. If it's important, we might want to move the test suite to runtime-extra-platforms.

Author: agocke
Assignees: -
Labels:

area-NativeAOT-coreclr

Milestone: -

@MichalStrehovsky
Copy link
Member

The checked leg does multimodule testing so that one adds a couple minutes to the build because we compile the entire framework. We also run the Loader and Interop tests there.

The checked leg also does all sorts of event pipe testing. Most recently we added quite a few extra tests to it: #89976 (comment)

We might want to make a better call on what is a smoke test vs what is okay to just run as part of extra platforms (we do run all of the above, except for multimodule testing, in extra platforms). IIRC the event pipe tests take more than Loader+Interop combined and they also depend on libs.oob subset so we need to spend time building things like System.Speech just for event pipe testing sake (#89153 (comment)).

Cc @LakshanF @elinor-fung

@agocke agocke added this to AppModel Sep 18, 2023
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Oct 2, 2023
@ghost ghost removed in-pr There is an active PR which will close this issue when it is merged untriaged New issue has not been triaged by the area owner labels Oct 2, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants