Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter fails occasionally #93229

Closed
akoeplinger opened this issue Oct 9, 2023 · 2 comments
Labels
area-Extensions-Options blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab
Milestone

Comments

@akoeplinger
Copy link
Member

akoeplinger commented Oct 9, 2023

There seems to be some non-deterministic behavior since the assert fails like this which suggests the classes were generated in a different order:

Assert.Equal() Failure
                                 ↓ (pos 128490)
Expected: ··· class __SourceGen__MinLengthAttribute : global::System.Compo···
Actual:   ··· class __SourceGen__RangeAttribute : global::System.Component···
                                 ↑ (pos 128490)

   at Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter() in /_/src/libraries/Microsoft.Extensions.Options/tests/SourceGenerationTests/EmitterTests.cs:line 56
--- End of stack trace from previous location ---

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=431517
Build error leg or test failing: Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter
Pull request: #93201

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": "",
  "ErrorPattern": "Actual:.*class __SourceGen__RangeAttribute",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=431517
Error message validated: Actual:.*class __SourceGen__RangeAttribute
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 10/9/2023 3:03:46 PM UTC

Report

Build Definition Test Pull Request
432677 dotnet/runtime Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter #93037
432608 dotnet/runtime Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter #93197
432557 dotnet/runtime Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter #93262
432491 dotnet/runtime Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter #93197
432473 dotnet/runtime Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter #92974
432470 dotnet/runtime Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter #93037
432457 dotnet/runtime Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter #93259
432437 dotnet/runtime Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter #93258
432431 dotnet/runtime Microsoft.Extensions.Options.SourceGeneration.Tests.WorkItemExecution
432376 dotnet/runtime Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter
432300 dotnet/runtime Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter #93248
432284 dotnet/runtime Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter #93214
432104 dotnet/runtime Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter #93231
432245 dotnet/runtime Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter #93224
432201 dotnet/runtime Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter #92057
432200 dotnet/runtime Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter #92057
432159 dotnet/runtime Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter #93238
432154 dotnet/runtime Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter #88136
432139 dotnet/runtime Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter #93242
432075 dotnet/runtime Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter #90436
432085 dotnet/runtime Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter #93214
432035 dotnet/runtime Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter #93182
431967 dotnet/runtime Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter #93219
431893 dotnet/runtime Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter #93066
431774 dotnet/runtime Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter #92931
431878 dotnet/runtime Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter #93214
431676 dotnet/runtime Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter #93064
431694 dotnet/runtime Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter #93213
431633 dotnet/runtime Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter #92057
431517 dotnet/runtime Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter #93201
431501 dotnet/runtime Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter #93135
431543 dotnet/runtime Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter
431496 dotnet/runtime Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter #93119
431489 dotnet/runtime Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter
431474 dotnet/runtime Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter
431397 dotnet/runtime Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter #93193

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
22 36 36
@akoeplinger akoeplinger added blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' area-Extensions-Options Known Build Error Use this to report build issues in the .NET Helix tab labels Oct 9, 2023
@ghost
Copy link

ghost commented Oct 9, 2023

Tagging subscribers to this area: @dotnet/area-extensions-options
See info in area-owners.md if you want to be subscribed.

Issue Details

There seems to be some non-deterministic behavior since the assert fails like this which suggests the classes were generated in a different order:

Assert.Equal() Failure
                                 ↓ (pos 128490)
Expected: ··· class __SourceGen__MinLengthAttribute : global::System.Compo···
Actual:   ··· class __SourceGen__RangeAttribute : global::System.Component···
                                 ↑ (pos 128490)

   at Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter() in /_/src/libraries/Microsoft.Extensions.Options/tests/SourceGenerationTests/EmitterTests.cs:line 56
--- End of stack trace from previous location ---

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=431517
Build error leg or test failing: Microsoft.Gen.OptionsValidation.Test.EmitterTests.TestEmitter
Pull request: #93201

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": "",
  "ErrorPattern": "Actual:.*class __SourceGen__RangeAttribute",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}
Author: akoeplinger
Assignees: -
Labels:

blocking-clean-ci, area-Extensions-Options, Known Build Error

Milestone: -

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Oct 9, 2023
@tarekgh tarekgh added this to the 9.0.0 milestone Oct 10, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Oct 10, 2023
@tarekgh
Copy link
Member

tarekgh commented Oct 10, 2023

This should be fixed now by #93260 which merged yesterday at 7:00 PM pacific time.

@tarekgh tarekgh closed this as completed Oct 10, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Extensions-Options blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab
Projects
None yet
Development

No branches or pull requests

2 participants