WIP: experimental LoadLibrary monitoring in CoreCLR native runtime #93258
+99
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
This was referenced Oct 10, 2023
jkotas
reviewed
Oct 10, 2023
| { | ||
| int64_t before = GetPreciseTickCount(); | ||
|
|
||
| HANDLE handle = CreateFileW( |
There was a problem hiding this comment.
This may not be doing what you expect.
Windows uses separate caches for data files and PE binaries. PE binaries are cached in the "mapped" layout. I am not sure whether Windows is able to create the "mapped" layout from the raw data cache.
|
@trylek, are you still working on this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an initial step towards analyzing ASP.NET startup perf I have added bits of instrumentation to the native CoreCLR runtime to measure LoadLibrary performance. According to my initial measurements there is a vast difference between Windows and Linux w.r.t. LoadLibrary perf; as a first step I would be grateful if you could double-check my implementation for obvious flaws or overlookings, after that we can drill into more detail regarding the actual numbers. I also think it might be useful to figure out how to merge this in somehow to make such measurements repeatable, I'm looking forward to any feedback you might have.
Thanks
Tomas