[wasi] Improve error message for missing WASI SDK

[RReverser]

Description

Trying to build a project targeting wasi-wasm with latest preview results in:

C:\Program Files\dotnet\packs\Microsoft.NET.Runtime.WebAssembly.Wasi.Sdk\8.0.0-rc.2.23479.6\Sdk\WasiApp.Native.targets(54,5): error : Could not fin
d wasi-sdk. Either set $(WASI_SDK_PATH), or use workloads to get the sdk. SDK is required for building native files.

Reproduction Steps

Build any project with <RuntimeIdentifier>wasi-wasm</RuntimeIdentifier>, e.g. the default wasi console template while not having WASI SDK installed globally.

Expected behavior

It should provision WASI SDK automatically when installing the wasi-experimental workload. It seems there is some code for this in the repo

runtime/src/mono/mono.proj

Lines 174 to 186 in af0227f

	<Target Name="ProvisionWasiSdk"
	Condition="'$(ShouldProvisionWasiSdk)' == 'true' and '$(SkipMonoCrossJitConfigure)' != 'true'">
	<ReadLinesFromFile File="$(MSBuildThisFileDirectory)/wasi/wasi-sdk-version.txt">
	<Output TaskParameter="Lines" ItemName="_VersionLines" />
	</ReadLinesFromFile>
	<PropertyGroup>
	<WasiLocalPath>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'wasi'))</WasiLocalPath>
	<WasiSdkVersion>%(_VersionLines.Identity)</WasiSdkVersion>
	<WasiSdkUrl>https://github.com/WebAssembly/wasi-sdk/releases/download/wasi-sdk-$(WasiSdkVersion)/wasi-sdk-$(WasiSdkVersion).0-linux.tar.gz</WasiSdkUrl>
	<WasiSdkUrl Condition="'$(HostOS)' == 'osx'" >https://github.com/WebAssembly/wasi-sdk/releases/download/wasi-sdk-$(WasiSdkVersion)/wasi-sdk-$(WasiSdkVersion).0-macos.tar.gz</WasiSdkUrl>
	<WasiSdkUrl Condition="'$(HostOS)' == 'windows'" >https://github.com/WebAssembly/wasi-sdk/releases/download/wasi-sdk-$(WasiSdkVersion)/wasi-sdk-$(WasiSdkVersion).0.m-mingw.tar.gz</WasiSdkUrl>
	</PropertyGroup>

but I guess it's not hooked up all the way?

Alternatively, at least provide a clear error message on how to retrieve one manually for now.

Actual behavior

The error message says

or use workloads to get the sdk

even though that doesn't seem to be supported.

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

[ghost]

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

Trying to build a project targeting wasi-wasm with latest preview results in:

C:\Program Files\dotnet\packs\Microsoft.NET.Runtime.WebAssembly.Wasi.Sdk\8.0.0-rc.2.23479.6\Sdk\WasiApp.Native.targets(54,5): error : Could not fin
d wasi-sdk. Either set $(WASI_SDK_PATH), or use workloads to get the sdk. SDK is required for building native files.

Reproduction Steps

Build any project with <RuntimeIdentifier>wasi-wasm</RuntimeIdentifier>, e.g. the default wasi console template while not having WASI SDK installed globally.

Expected behavior

It should provision WASI SDK automatically when installing the wasi-experimental workload. It seems there is some code for this in the repo

runtime/src/mono/mono.proj

Lines 174 to 186 in af0227f

	<Target Name="ProvisionWasiSdk"
	Condition="'$(ShouldProvisionWasiSdk)' == 'true' and '$(SkipMonoCrossJitConfigure)' != 'true'">
	<ReadLinesFromFile File="$(MSBuildThisFileDirectory)/wasi/wasi-sdk-version.txt">
	<Output TaskParameter="Lines" ItemName="_VersionLines" />
	</ReadLinesFromFile>
	<PropertyGroup>
	<WasiLocalPath>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'wasi'))</WasiLocalPath>
	<WasiSdkVersion>%(_VersionLines.Identity)</WasiSdkVersion>
	<WasiSdkUrl>https://github.com/WebAssembly/wasi-sdk/releases/download/wasi-sdk-$(WasiSdkVersion)/wasi-sdk-$(WasiSdkVersion).0-linux.tar.gz</WasiSdkUrl>
	<WasiSdkUrl Condition="'$(HostOS)' == 'osx'" >https://github.com/WebAssembly/wasi-sdk/releases/download/wasi-sdk-$(WasiSdkVersion)/wasi-sdk-$(WasiSdkVersion).0-macos.tar.gz</WasiSdkUrl>
	<WasiSdkUrl Condition="'$(HostOS)' == 'windows'" >https://github.com/WebAssembly/wasi-sdk/releases/download/wasi-sdk-$(WasiSdkVersion)/wasi-sdk-$(WasiSdkVersion).0.m-mingw.tar.gz</WasiSdkUrl>
	</PropertyGroup>

but I guess it's not hooked up all the way?

Alternatively, at least provide a clear error message on how to retrieve one manually for now.

Actual behavior

The error message says

or use workloads to get the sdk

even though that doesn't seem to be supported.

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

Author:	RReverser
Assignees:	-
Labels:	arch-wasm, untriaged, area-Build-mono, os-wasi
Milestone:	-

[radical]

It seems there is some code for this in the repo

That code is specifically for provisioning the sdk for the runtime build.

It should provision WASI SDK automatically when installing the wasi-experimental workload.

The aim is to make it be a part of the workload itself. This work is being tracked in #82788 . cc @directhex

[RReverser]

Yeah I saw the other issue, but wanted to raise one specifically for the error message (hence the title before it was edited).

As far as I understand, the actual integration will take some time, and for the .NET 8.0 release it would be good to fix the error message itself so that it doesn't confuse other users. I believe for now it should just point users to the official repo they can install WASI SDK from.

[RReverser]

Do you mind if I edit the title back so that this issue is not accidentally confused with / as a duplicate of #82788?

[radical]

Do you mind if I edit the title back so that this issue is not accidentally confused with / as a duplicate of #82788?

Indeed the message can be improved.

[RReverser]

Oh oops we edited at the same time 😅