Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NativeAOT] Enable EventSource on more tests #95039

Open
VSadov opened this issue Nov 20, 2023 · 4 comments
Open

[NativeAOT] Enable EventSource on more tests #95039

VSadov opened this issue Nov 20, 2023 · 4 comments

Comments

@VSadov
Copy link
Member

VSadov commented Nov 20, 2023

Lately we have seen a few stress bugs that reproduce only when EventSource is enabled and events are consumed (i.e #94241, #94873)

The set of tests that enable EventSource is relatively small though, so even if there is a bug, the repro rate could be one occurrence per few days or longer.

If that is possible and is not too expensive in terms of increasing the time that tests take, I'd recommend enabling EventSource on a few more tests. The following tests were known in the past to be relatively "intense" - enough to uncover various stress issues. Perhaps we can do just these?

System.Collections\tests\System.Collections.Tests.csproj
System.Collections.Immutable\tests\System.Collections.Immutable.Tests.csproj
System.Collections.Concurrent\tests\System.Collections.Concurrent.Tests.csproj
System.Runtime\tests\System.Runtime.Tests.csproj
System.Memory\tests\System.Memory.Tests.csproj
System.Reflection.Metadata\tests\System.Reflection.Metadata.Tests.csproj

Any suggestions on what should be added/removed in this set are welcome.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Nov 20, 2023
@ghost
Copy link

ghost commented Nov 20, 2023

Tagging subscribers to this area: @dotnet/area-system-collections
See info in area-owners.md if you want to be subscribed.

Issue Details

Lately we have seen a few stress bugs that reproduce only when EventSource is enabled and events are consumed (i.e #94241, #94873)

The set of tests that enable EventSource is relatively small though, so even if there is a bug, the repro rate could be one occurrence per few days or longer.

If that is possible and is not too expensive in terms of increasing the time that tests take, I'd recommend enabling EventSource on a few more tests. The following tests were known in the past to be relatively "intense" - enough to uncover various stress issues. Perhaps we can do just these?

System.Collections\tests\System.Collections.Tests.csproj
System.Collections.Immutable\tests\System.Collections.Immutable.Tests.csproj
System.Collections.Concurrent\tests\System.Collections.Concurrent.Tests.csproj
System.Runtime\tests\System.Runtime.Tests.csproj
System.Memory\tests\System.Memory.Tests.csproj
System.Reflection.Metadata\tests\System.Reflection.Metadata.Tests.csproj

Any suggestions on what should be added/removed in this set are welcome.

Author: VSadov
Assignees: -
Labels:

area-System.Collections, untriaged

Milestone: -

@ghost
Copy link

ghost commented Nov 20, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Lately we have seen a few stress bugs that reproduce only when EventSource is enabled and events are consumed (i.e #94241, #94873)

The set of tests that enable EventSource is relatively small though, so even if there is a bug, the repro rate could be one occurrence per few days or longer.

If that is possible and is not too expensive in terms of increasing the time that tests take, I'd recommend enabling EventSource on a few more tests. The following tests were known in the past to be relatively "intense" - enough to uncover various stress issues. Perhaps we can do just these?

System.Collections\tests\System.Collections.Tests.csproj
System.Collections.Immutable\tests\System.Collections.Immutable.Tests.csproj
System.Collections.Concurrent\tests\System.Collections.Concurrent.Tests.csproj
System.Runtime\tests\System.Runtime.Tests.csproj
System.Memory\tests\System.Memory.Tests.csproj
System.Reflection.Metadata\tests\System.Reflection.Metadata.Tests.csproj

Any suggestions on what should be added/removed in this set are welcome.

Author: VSadov
Assignees: -
Labels:

untriaged, area-NativeAOT-coreclr

Milestone: -

@VSadov
Copy link
Member Author

VSadov commented Nov 20, 2023

CC: @LakshanF

@MichalStrehovsky
Copy link
Member

Should we instead have a dedicated pipeline leg that runs everything with EventSource enabled? It might also need to enable some listeners because this would all likely be no-op without listeners (we just compile more code that then never runs).

The tests where we currently enable EventSource all have listeners. The tests where we didn't enable EventSource didn't have any listeners as part of the test.

@LakshanF LakshanF self-assigned this Nov 25, 2023
@agocke agocke added this to the Future milestone May 15, 2024
@agocke agocke removed the untriaged New issue has not been triaged by the area owner label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

4 participants