AccessViolation in crossgen Microsoft.CSharp.dll

[eerhardt]

See dotnet/core-setup#3662 (comment)

This is blocking taking new coreclr bits into core-setup.

To repro: checkout @dotnet-maestro-bot's change in that PR, and "build.cmd/sh".

The command that is failing is:

F:\git\core-setup\packages\transport.runtime.win-x64.microsoft.netcore.runtime.coreclr\2.1.0-preview2-26202-06\tools\crossgen.exe
-readytorun
-platform_assemblies_paths F:\git\core-setup\Bin/win-x64.Debug\\crossgen/Microsoft.NETCore.App/win-x64/runtimes/win-x64/lib/netcoreapp2.1/;F:\git\core-setup\packages\transport.runtime.win-x64.Microsoft.NETCore.Runtime.CoreCLR\2.1.0-preview2-26202-06\runtimes\win-x64\native\
-CreatePDB
F:\git\core-setup\Bin/win-x64.Debug/symbols//Microsoft.NETCore.App/runtimes/win-x64/lib/netcoreapp2.1
F:\git\core-setup\Bin/win-x64.Debug\\crossgen/Microsoft.NETCore.App/win-x64/runtimes/win-x64/lib/netcoreapp2.1/Microsoft.CSharp.dll

I attached WinDBG to this process and I'm getting:

(1178f4.119378): Access violation - code c0000005 (first chance)
First chance exceptions are reported before any exception handling.
This exception may be expected and handled.
crossgen!EECodeInfo::GetMethodRegionInfo+0x7 [inlined in crossgen!NGenModulePdbWriter::WriteMethodPDBData+0x72]:
00007ff7`2188a25e 488b07          mov     rax,qword ptr [rdi] ds:00000000`00000000=????????????????

crossgen!EECodeInfo::GetMethodRegionInfo + 0x7
crossgen!NGenModulePdbWriter::WriteMethodPDBData + 0x72
crossgen!NGenModulePdbWriter::WritePDBData + 0x97c
crossgen!NGenPdbWriter::WritePDBDataForModule + 0x1e3
crossgen!CreatePdb + 0x186
crossgen!Zapper::CreatePdbInCurrentDomain + 0x278
crossgen!`Zapper::CreatePdb'::`2'::Callback::doCallback + 0x29
crossgen!Zapper::InvokeDomainCallback + 0xa
crossgen!Zapper::CreatePdb + 0x65
crossgen!CreatePDBWorker + 0x20e
crossgen!wmain + 0x99f
crossgen!invoke_main + 0x22
crossgen!__scrt_common_main_seh + 0x11d
KERNEL32!BaseThreadInitThunk + 0x14
ntdll!RtlUserThreadStart + 0x21

/cc @RussKeldorph @sergiy-k @jkotas

[RussKeldorph]

@dotnet/debugger-team @dotnet/jit-contrib in case this rings a bell.

[RussKeldorph]

Oops, meant @dotnet/dotnet-diag

[sandreenko]

Without -readytorun and -CreatePDB F:\git\core-setup\Bin/win-x64.Debug/symbols//Microsoft.NETCore.App/runtimes/win-x64/lib/netcoreapp2.1:

F:\git\core-setup\packages\transport.runtime.win-x64.microsoft.netcore.runtime.coreclr\2.1.0-preview2-26202-06\tools\crossgen.exe 
-platform_assemblies_paths F:\git\core-setup\Bin/win-x64.Debug\\crossgen/Microsoft.NETCore.App/win-x64/runtimes/win-x64/lib/netcoreapp2.1/;F:\git\core-setup\packages\transport.runtime.win-x64.Microsoft.NETCore.Runtime.CoreCLR\2.1.0-preview2-26202-06\runtimes\win-x64\native\ F:\git\core-setup\Bin/win-x64.Debug\\crossgen/Microsoft.NETCore.App/win-x64/runtimes/win-x64/lib/netcoreapp2.1/Microsoft.CSharp.dll

it hits:

Unable to load Jit Compiler: clrjit.dll, hr=0x8007007e
Error: compilation failed for "F:\git\core-setup\Bin/win-x64.Debug\\crossgen/Microsoft.NETCore.App/win-x64/runtimes/win-x64/lib/netcoreapp2.1/Microsoft.CSharp.dll" (0x8007007e)

[eerhardt]

When you specify -CreatePDB, it doesn't generate code, it generates a native .pdb file for the ready to run image. Thus you don't need to pass in the path to the JIT.

When you don't specify -CreatePDB, it generates code, so you need to also pass in the path to the clrjit.dll.

So if you drop -CreatePDB, you need to add -JITPath F:\git\core-setup\packages\transport.runtime.win-x64.Microsoft.NETCore.Jit\2.1.0-preview2-26202-06\runtimes\win-x64\native\clrjit.dll

[sandreenko]

Ok, it is our regression, the bad change is dotnet/coreclr#15801.

To repro:

build.cmd x64 debug skiptests
tests\runtest.cmd x64 debug GenerateLayoutOnly

set core_root=<path to core_root, C:\git\coreclr\bin\tests\Windows_NT.x64.Debug\Tests\Core_Root>

crossgen.exe /Platform_Assemblies_Paths %core_root% %core_root%\Microsoft.CSharp.dll

crossgen.exe -platform_assemblies_paths %core_root% -CreatePDB %core_root% %core_root%\Microsoft.CSharp.ni.dll

output:

C:\git\coreclr\bin\tests\Windows_NT.x64.Debug\Tests\Core_Root>crossgen.exe -platform_assemblies_paths %core_root% -CreatePDB %core_root% %core_root%\Microsoft.CSharp.ni.dll
Microsoft (R) CoreCLR Native Image Generator - Version 4.5.22220.0
Copyright (c) Microsoft Corporation.  All rights reserved.


Assert failure(PID 20620 [0x0000508c], Thread: 29244 [0x723c]): !"Unknown FIXUP_BLOB_KIND"

CROSSGEN! LoadDynamicInfoEntry + 0x269 (0x00007ff6`6d07ce69)
CROSSGEN! Module::FixupNativeEntry + 0x98 (0x00007ff6`6d01bec8)
CROSSGEN! Module::FixupDelayListAux<Module * __ptr64,int (__cdecl Module::*)(CORCOMPILE_IMPORT_SECTION * __ptr64,unsigned __int64,unsigned __int64 * __ptr64) __ptr64> + 0x1DB (0x00007ff6`6d0eddeb)
CROSSGEN! Module::FixupDelayList + 0x91 (0x00007ff6`6d0ef351)
CROSSGEN! ReadyToRunInfo::GetEntryPoint + 0x272 (0x00007ff6`6d0ef9a2)
CROSSGEN! ReadyToRunInfo::MethodIterator::GetMethodStartAddress + 0x2E (0x00007ff6`6d0efdfe)
CROSSGEN! NGenModulePdbWriter::WritePDBData + 0xD37 (0x00007ff6`6cf8ffd7)
CROSSGEN! NGenPdbWriter::WritePDBDataForModule + 0xA5 (0x00007ff6`6cf90265)
CROSSGEN! CreatePdb + 0x175 (0x00007ff6`6cf90ab5)
CROSSGEN! Zapper::CreatePdbInCurrentDomain + 0x3E5 (0x00007ff6`6d267215)
    File: c:\git\coreclr\src\vm\jitinterface.cpp Line: 13659
    Image: C:\git\coreclr\bin\tests\Windows_NT.x64.Debug\Tests\Core_Root\crossgen.exe

@AndyAyersMS are you around to fix that?

[AndyAyersMS]

Sure, let me look.

[AndyAyersMS]

There's a missing arg to GetEntryPoint hidden by default args. Fix should be simple.