Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tests in parseTest are never run. #96679

Closed
kzrnm opened this issue Jan 9, 2024 · 1 comment · Fixed by #96744
Closed

Some tests in parseTest are never run. #96679

kzrnm opened this issue Jan 9, 2024 · 1 comment · Fixed by #96744

Comments

@kzrnm
Copy link
Contributor

kzrnm commented Jan 9, 2024

Description

Type t = typeof(BigInteger).Assembly.GetType("System.Numerics.BigNumber");

System.Numerics.BigNumber has been removed so this will be null.

Therefore, tests that use RunWithFakeThreshold will not be executed.

BigNumberTools.Utils.RunWithFakeThreshold("s_naiveThreshold", 0, Test);

Reproduction Steps

cd src/libraries/System.Runtime.Numerics/tests
dotnet build /t:Test /p:XUnitOptions="-class System.Numerics.Tests.parseTest"

Expected behavior

Tests that use RunWithFakeThreshold will be executed.

Actual behavior

Tests that use RunWithFakeThreshold will not be executed.

Regression?

#85978

Known Workarounds

No response

Configuration

No response

Other information

No response

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jan 9, 2024
@ghost
Copy link

ghost commented Jan 9, 2024

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

Description

Type t = typeof(BigInteger).Assembly.GetType("System.Numerics.BigNumber");

System.Numerics.BigNumber has been removed so this will be null.

Therefore, tests that use RunWithFakeThreshold will not be executed.

BigNumberTools.Utils.RunWithFakeThreshold("s_naiveThreshold", 0, Test);

Reproduction Steps

cd src/libraries/System.Runtime.Numerics/tests
dotnet build /t:Test /p:XUnitOptions="-class System.Numerics.Tests.parseTest"

Expected behavior

Tests that use RunWithFakeThreshold will be executed.

Actual behavior

Tests that use RunWithFakeThreshold will not be executed.

Regression?

#85978

Known Workarounds

No response

Configuration

No response

Other information

No response

Author: kzrnm
Assignees: -
Labels:

area-System.Numerics

Milestone: -

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jan 9, 2024
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jan 10, 2024
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jan 10, 2024
@ghost ghost removed in-pr There is an active PR which will close this issue when it is merged untriaged New issue has not been triaged by the area owner labels Jan 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant