Fix assertion at System.Numerics.BigIntegerCalculator.Multiply #96744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-numerics |
|
Bringing commits from other pull requests may confuse reviewers. |
|
@huoyaoyuan Noted. I'll change this pull request to draft until the preceding pull requests are resolved. |
|
The other PR is merged now |
Use typeof and nameof directly.
Use typeof and nameof as in BigNumberTools.
kzrnm
force-pushed
the
fix/BigIntegerRegression
branch
from
6e81ea3 to
5407108
Compare
2 tasks
tannergooding
approved these changes
Jan 12, 2024
tmds
pushed a commit
to tmds/runtime
that referenced
this pull request
Jan 23, 2024
…t#96744) * Fix BigNumberTools Use typeof and nameof directly. * Fix BigIntTools Use typeof and nameof as in BigNumberTools. * RunWithFakeThreshold hack * Add regression test * Fix assertion
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #96679 and Fix #94610