Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Assertion failed '!"Extra flags on tree"' during 'Post-Morph' #97524

Closed
amanasifkhalid opened this issue Jan 25, 2024 · 5 comments · Fixed by #97541
Closed

JIT: Assertion failed '!"Extra flags on tree"' during 'Post-Morph' #97524

amanasifkhalid opened this issue Jan 25, 2024 · 5 comments · Fixed by #97541
Assignees
@jakobbotsch
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs Known Build Error Use this to report build issues in the .NET Helix tab
Milestone
9.0.0

Comments

@amanasifkhalid
Copy link
Member

amanasifkhalid commented Jan 25, 2024 •
edited by build-analysis bot
Loading

Error Blob

{
  "ErrorMessage": "",
  "BuildRetry": false,
  "ErrorPattern": "Extra flags on tree",
  "ExcludeConsoleLog": false
}

Reproduction Steps

Example test run: https://dev.azure.com/dnceng-public/public/_build/results?buildId=540840&view=results
Example console log: https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-97488-merge-c4d5c6c8a7f64d9baf/System.Runtime.InteropServices.Tests/1/console.3fbb3808.log?helixlogtype=result

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=540840
Error message validated: Extra flags on tree
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 1/25/2024 9:05:04 PM UTC

Report

Build Definition Test Pull Request
541598 dotnet/runtime System.Runtime.InteropServices.Tests.WorkItemExecution
540840 dotnet/runtime System.Runtime.InteropServices.Tests.WorkItemExecution #97488
540774 dotnet/runtime System.Runtime.InteropServices.Tests.WorkItemExecution #97517

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
3 3 3
@amanasifkhalid amanasifkhalid added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs Known Build Error Use this to report build issues in the .NET Helix tab labels Jan 25, 2024
@ghost
Copy link

ghost commented Jan 25, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Error Blob

{
  "ErrorMessage": "",
  "BuildRetry": false,
  "ErrorPattern": "Assertion failed '!"Extra flags on tree"'.*TryMatchAtCurrentPosition.*during 'Post-Morph'",
  "ExcludeConsoleLog": false
}

Reproduction Steps

Example test run: https://dev.azure.com/dnceng-public/public/_build/results?buildId=540840&view=results
Example console log: https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-97488-merge-c4d5c6c8a7f64d9baf/System.Runtime.InteropServices.Tests/1/console.3fbb3808.log?helixlogtype=result

Author: amanasifkhalid
Assignees: -
Labels:

area-CodeGen-coreclr, blocking-clean-ci-optional, Known Build Error
Milestone: -

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jan 25, 2024
@amanasifkhalid
Copy link
Member Author

cc @dotnet/jit-contrib. This is blocking runtime-coreclr libraries-jitstress.

@amanasifkhalid amanasifkhalid added this to the 9.0.0 milestone Jan 25, 2024
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Jan 25, 2024
@jakobbotsch jakobbotsch self-assigned this Jan 25, 2024
@jakobbotsch
Copy link
Member

Most likely from one of my recent changes. Odd though since I ran libraries-jitstress in them.

@amanasifkhalid amanasifkhalid mentioned this issue Jan 25, 2024
Merged
@jakobbotsch
Copy link
Member

Gah, the libraries-jitstress run in #97411 did have those failures, I just misidentified them as #97437.

jakobbotsch added a commit to jakobbotsch/runtime that referenced this issue Jan 26, 2024
@jakobbotsch
JIT: Improve consistency around indir flags; directly copy flags in `…
a16dc86 
…gtCloneExpr`

- Switch `GT_STORE_DYN_BLK` to be on the same plan as other indirs; add
  a `gtNewStoreDynBlkNode` and use `gtInitializeIndirNode` to set its
  flags correctly. Add support for it to
  `GenTree::SetIndirExceptionFlags`. Remove conservative flag setting from its
  constructor.
- Fix propagation of `GTF_EXCEPT` from `GT_CMPXCHG`'s data source inside
  `GenTree::SetIndirExceptionFlags`
- Set flags directly from the source node in `gtCloneExpr`

Fix dotnet#97524
@jakobbotsch jakobbotsch mentioned this issue Jan 26, 2024
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jan 26, 2024
@amanasifkhalid
Copy link
Member Author

Gah, the libraries-jitstress run in #97411 did have those failures, I just misidentified them as #97437.

No worries; thanks for the fix!

jakobbotsch added a commit that referenced this issue Jan 26, 2024
@jakobbotsch
JIT: Improve consistency around indir flags; directly copy flags in `…
eab0939 
…gtCloneExpr` (#97541)

- Switch `GT_STORE_DYN_BLK` to be on the same plan as other indirs; add
  a `gtNewStoreDynBlkNode` and use `gtInitializeIndirNode` to set its
  flags correctly. Add support for it to
  `GenTree::SetIndirExceptionFlags`. Remove conservative flag setting from its
  constructor.
- Fix propagation of `GTF_EXCEPT` from `GT_CMPXCHG`'s data source inside
  `GenTree::SetIndirExceptionFlags`
- Set flags directly from the source node in `gtCloneExpr`

Fix #97524
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jan 26, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jakobbotsch jakobbotsch

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs Known Build Error Use this to report build issues in the .NET Helix tab
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

JIT: Improve consistency around indir flags; directly copy flags in gtCloneExpr jakobbotsch/runtime
2 participants
@jakobbotsch @amanasifkhalid